-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification Request: homebridge-sleepme #757
Comments
|
I have installed the plugin and set up as a child bridge. I have the following (minimal) config: {
"platform": "SleepmeHomebridgePlugin",
"_bridge": {
"username": "0E:43:1A:1A:1E:EE",
"port": 37163
}
} This is leading to a crash loop with the following message:
Here you need to check that |
Thanks @bwp91 - I'll get this fixed soon. |
@bwp91 in principle, would it be possible for homebridge itself to validate the config against the definition in the schema file used to configure the UI? Is there a way to do that now? I would l like to avoid adding a json schema library to my plugin directly, to minimize dependencies. I can see plugins using a helper function like |
Hi @bwp91 - I just published a new release. This should be ready for you to retest the config behavior. |
Plugin Name
homebridge-sleepme
Link To GitHub Repo
https://github.com/LukeWinikates/homebridge-sleepme
Plugin Icon (Optional)
No response
The plugin does not offer the same nor less functionality than that of any existing verified plugin.
🟢 Yes
The plugin successfully installs and does not start unless it is configured.
🟢 Yes
The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
🟢 Yes
The plugin does not contain any analytics or calls that enable you to track the user.
🟢 Yes
If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.
🟢 Yes
The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.
🟢 Yes
More Information
This is my first Homebridge plugin, and is quite simple. I'd love to receive the feedback that comes with the verification process and improve the plugin accordingly. It's for a niche family of devices, and I don't expect the utilization to ever be very high.
I answered the "The plugin successfully installs and does not start unless it is configured" question as "yes", but I'm not sure I understand what "start" means in this case. I'd be happy to add logic to short-circuit startup if no API keys are configured. As is, if unconfigured, the plugin would find no API keys at startup and wouldn't find anything to start up and loop over.
The device this plugin supports has a water tank, which gets used up over time and needs to be refilled. I wanted to expose this information in the plugin, but the only accessory/characteristic that mapped at all to this was a "battery". I'd love any suggestions for a better way of handling that, if possible.
The text was updated successfully, but these errors were encountered: