Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebridge-jci-hitachi-platform #678

Open
tasict opened this issue Jan 9, 2024 · 13 comments
Open

homebridge-jci-hitachi-platform #678

tasict opened this issue Jan 9, 2024 · 13 comments
Labels
pending the label given to a new verification/icon request

Comments

@tasict
Copy link

tasict commented Jan 9, 2024

Link To GitHub Repo

https://github.com/tasict/homebridge-jci-hitachi-platform

Link To NPM Package

https://www.npmjs.com/package/homebridge-jci-hitachi-platform

Plugin Icon (Optional)

No response

@tasict tasict added the pending the label given to a new verification/icon request label Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

✅ Pre-checks completed successfully.

@bwp91
Copy link
Contributor

bwp91 commented Feb 11, 2024

This plugin is also showing the homebridge verified badge on the readme when it is not verified yet

@bwp91 bwp91 added awaiting-user-reply use after review has started - awaiting user to reply to a comment and removed pending the label given to a new verification/icon request labels Feb 11, 2024
@tasict
Copy link
Author

tasict commented Feb 11, 2024

Ok,I will remove it and update.

@tasict
Copy link
Author

tasict commented Feb 13, 2024

@bwp91 Hi, I have modified the code and documentation. Please assist in reviewing the latest version. Thank you.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale used for stale issues label Mar 14, 2024
@tasict
Copy link
Author

tasict commented Mar 14, 2024

@bwp91 Any update?

@github-actions github-actions bot removed the stale used for stale issues label Mar 15, 2024
@bwp91 bwp91 added currently-reviewing use for starting a review - adds a comment with the verification list with empty checkboxes and removed awaiting-user-reply use after review has started - awaiting user to reply to a comment labels Mar 16, 2024
Copy link

github-actions bot commented Mar 16, 2024

  • General
    • The plugin must be of type dynamic platform.
    • The plugin must not offer the same nor less functionality than that of any existing verified plugin.
  • Repo
    • The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
    • A GitHub release should be created for every new version of your plugin, with release notes.
  • Environment
    • The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
    • The plugin must successfully install and not start unless it is configured.
    • The plugin must not execute post-install scripts that modify the users' system in any way.
    • The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • Codebase
    • The plugin must implement the Homebridge Plugin Settings GUI.
    • The plugin must not contain any analytics or calls that enable you to track the user.
    • If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
    • The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.



Comment /check to run checks again.

@bwp91
Copy link
Contributor

bwp91 commented Mar 16, 2024

Hi @tasict

I just installed the plugin but have not yet configured it. When I restart Homebridge I get this in the logs (although it does not seem to affect my homebridge).

[16/03/2024, 18:22:57] ====================
[16/03/2024, 18:22:57] ERROR LOADING PLUGIN homebridge-jci-hitachi-platform:
[16/03/2024, 18:22:57] Error: AWS CRT binary not present in any of the following locations:
        /usr/local/lib/node_modules/homebridge-jci-hitachi-platform/node_modules/aws-crt/dist/bin/linux-arm-glibc/aws-crt-nodejs.node
    at Object.<anonymous> (/usr/local/lib/node_modules/homebridge-jci-hitachi-platform/node_modules/aws-crt/lib/native/binding.js:88:11)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/homebridge-jci-hitachi-platform/node_modules/aws-crt/lib/native/auth.ts:15:1)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
[16/03/2024, 18:22:57] ====================

I noticed that the installation took a long time and seems to download a load of extra stuff (which is not necessarily an issue by itself).

I assume all this is from the aws-iot-device-sdk-v2 dependency.

In my Govee plugin I use aws-iot-device-sdk and tried the -v2 but reverted back due to all the extra stuff that happened during installation. Do you need to use the v2 with your plugin or would it be possible/easy to change to using the original aws-iot-device-sdk?

@bwp91 bwp91 added awaiting-user-reply use after review has started - awaiting user to reply to a comment and removed currently-reviewing use for starting a review - adds a comment with the verification list with empty checkboxes labels Mar 16, 2024
@tasict
Copy link
Author

tasict commented Mar 17, 2024

Because my plugins are newly written, I'm not very familiar with the aws-iot-device-sdk. I simply used it because Hitachi employs AWS's IoT service. During implementation, I found that there are two versions available. The official recommendation on the website is to use the newer v2 version. I also have concerns that the v1 version may be discontinued in the near future, so I initially chose the v2 version.

@bwp91 bwp91 added pending the label given to a new verification/icon request and removed awaiting-user-reply use after review has started - awaiting user to reply to a comment labels Mar 25, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale used for stale issues label Apr 25, 2024
@bwp91 bwp91 removed the stale used for stale issues label Apr 25, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale used for stale issues label May 26, 2024
@bwp91 bwp91 removed the stale used for stale issues label May 31, 2024
Copy link

github-actions bot commented Jul 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale used for stale issues label Jul 1, 2024
@bwp91 bwp91 removed the stale used for stale issues label Jul 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale used for stale issues label Aug 1, 2024
@bwp91 bwp91 removed the stale used for stale issues label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending the label given to a new verification/icon request
Projects
None yet
Development

No branches or pull requests

2 participants