Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articles with inline images not rendering correctly #1359

Open
dariusk opened this issue Nov 5, 2024 · 0 comments
Open

Articles with inline images not rendering correctly #1359

dariusk opened this issue Nov 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dariusk
Copy link

dariusk commented Nov 5, 2024

Steps to reproduce the problem

  1. In the web client, go to your search bar in v4.2.0+hometown-1.1.1 and put in https://kostyn.ca/fuck-sustainable-development-goals-have-yall-ever-heard-of-communism-reviewing-kohei-saitos-slow-down-the-degrowth-manifesto/, click Search
  2. You'll get a 500 error

Expected behaviour

A search result appears

Actual behaviour

A 500 error

Detailed description

As initially reported in Automattic/wordpress-activitypub#939

On a clean Hometown install when I put https://kostyn.ca/fuck-sustainable-development-goals-have-yall-ever-heard-of-communism-reviewing-kohei-saitos-slow-down-the-degrowth-manifesto/ into the search bar of the web client and search, I get a "500" error reported on the client side, and I get this in the logs:

08:20:48 web.1     | Completed 500 Internal Server Error in 6606ms (ActiveRecord: 58.1ms | Allocations: 180111)
08:20:48 web.1     | 
08:20:48 web.1     | 
08:20:48 web.1     |   
08:20:48 web.1     | ArgumentError (wrong number of arguments (given 1, expected 0)):
08:20:48 web.1     |   
08:20:48 web.1     | app/lib/activitypub/activity/create.rb:139:in `initialize'
08:20:48 web.1     | app/lib/activitypub/activity/create.rb:167:in `new'
08:20:48 web.1     | app/lib/activitypub/activity/create.rb:167:in `process_inline_images'
08:20:48 web.1     | app/lib/activitypub/activity/create.rb:81:in `process_status'
08:20:48 web.1     | app/lib/activitypub/activity/create.rb:58:in `block in create_status'
08:20:48 web.1     | app/models/concerns/lockable.rb:12:in `block (2 levels) in with_redis_lock'
08:20:48 web.1     | app/models/concerns/lockable.rb:10:in `block in with_redis_lock'
08:20:48 web.1     | app/lib/redis_configuration.rb:10:in `with'
08:20:48 web.1     | app/models/concerns/redisable.rb:9:in `with_redis'
08:20:48 web.1     | app/models/concerns/lockable.rb:9:in `with_redis_lock'
08:20:48 web.1     | app/lib/activitypub/activity/create.rb:52:in `create_status'
08:20:48 web.1     | app/lib/activitypub/activity/create.rb:15:in `perform'
08:20:48 web.1     | app/services/activitypub/fetch_remote_status_service.rb:55:in `call'
08:20:48 web.1     | app/services/fetch_remote_status_service.rb:12:in `call'
08:20:48 web.1     | app/services/resolve_url_service.rb:28:in `process_url'
08:20:48 web.1     | app/services/resolve_url_service.rb:16:in `call'
08:20:48 web.1     | app/services/search_service.rb:77:in `url_resource'
08:20:48 web.1     | app/services/search_service.rb:19:in `block in call'
08:20:48 web.1     | app/services/search_service.rb:15:in `call'
08:20:48 web.1     | app/controllers/api/v2/search_controller.rb:33:in `search_results'
08:20:48 web.1     | app/controllers/api/v2/search_controller.rb:12:in `index'
08:20:48 web.1     | app/controllers/concerns/localized.rb:11:in `set_locale'
08:20:48 web.1     | lib/mastodon/rack_middleware.rb:9:in `call'
08:20:48 web.1     | lib/public_file_server_middleware.rb:18:in `call'
08:20:48 sidekiq.1 |   Account Load (0.3ms)  SELECT "accounts"."id", "account

The problem is that I'm passing the wrong number of arguments to Ox -- I think maybe I upgraded Ox for security reasons, their API surface changed, and now there's an issue with sending a parameter to the initializer.

Specifications

v4.2.0+hometown-1.1.1

@dariusk dariusk added the bug Something isn't working label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant