MQTT $localip gets truncated

[pwrsoft]

Having an issue with Homie v2.0.0 MQTT $localip
it gets truncated in the last symbol when published in MQTT:
e.g. instead of "192.168.1.128" it gets "192.168.1.12", tested this on two nodes but with the same results.

[bertmelis]

try changing the file BootNormal.cpp on line 193:

snprintf(localIpStr, MAX_IP_STRING_LENGTH - 1, "%d.%d.%d.%d", localIp[0], localIp[1], localIp[2], localIp[3]);

to

snprintf(localIpStr, MAX_IP_STRING_LENGTH + 1, "%d.%d.%d.%d", localIp[0], localIp[1], localIp[2], localIp[3]);

If it works, you should also changed it BootConfig.cpp. But if this fix works, I would think the bug is that the IP gets truncated by 2 characters.

[pwrsoft]

Thank you for your reply and suggestion!
Checked the solution you provide - the IP is now OK!

One thing that changed too is the device id – is gets extended by 1 symbol (for some reason):
e.g. XXXXXXXXXf9 changed to XXXXXXXXXf93

[bertmelis]

The default device ID is actually the MAC address and hence is 12 characters long. It was a bug: see #296
The underlying cause was the same for this issue. You could propose a pull request for this solution (otherwise I will).

[pwrsoft]

Feel free to make a pull request 👍

[marvinroger]

Fixed with the above PR, thanks!