Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching over to browserify #20

Closed
wants to merge 2 commits into from
Closed

switching over to browserify #20

wants to merge 2 commits into from

Conversation

jcblw
Copy link
Contributor

@jcblw jcblw commented Jan 27, 2015

let me know what you guys think

fixes #19

@@ -1,10 +1,10 @@
<!doctype html>
<iframe width="600px" height="800px" src="http://gohone.com/Quiz/5407769cfae50de35b93a1c2?debug=true&embed=true" data-hone frameborder="0" data-resize="true">You Dont Support Iframes</iframe>
<script src="../build/embed.js" defer></script>
<iframe width="600px" height="800px" src="https://gohone.com/Quiz/5407769cfae50de35b93a1c2?debug=true&embed=true" data-hone frameborder="0" data-resize="true">You Dont Support Iframes</iframe>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we positive everything loads and renders perfectly over https://?

I seem to recall some issues with fonts or something not being served correctly over ssl. The wordpress site still having https-issues makes me think we need to double check our app too.

If you'd like, I'm happy to help out with this tomorrow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broskes this is an example page, i was testing it using srvdir which is only https which is why this change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not seeing stuff like this on your end?:
screenshot 2015-01-26 22 34 32
(they're a little blurry on purpose. sorry.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I do but that is just I assume because of the fonts they use for the quiz (not https) everything still logs correctly.

@jcblw jcblw closed this Jun 24, 2015
@jcblw jcblw reopened this Jun 24, 2015
@jcblw jcblw closed this Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browserify
2 participants