feat: add retention policy to gcs module [DA-3815] #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
thadchais
requested review from
ChristianWitts,
MXfive,
Sagart-cactus and
sunilhonest
olli-honest
reviewed
Sep 23, 2024
Terraform Format and Style 🖌
|
MXfive
previously approved these changes
Sep 23, 2024
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
thadchais
force-pushed
the
thadchai/da-3815-add-retention-lock-to-gcs-module
branch
from
2722113
to
a9b2a66
Compare
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
ChristianWitts
previously approved these changes
Sep 24, 2024
olli-honest
previously approved these changes
Sep 24, 2024
thadchais
dismissed stale reviews from olli-honest and ChristianWitts
via
e05606e
Terraform Format and Style 🖌
|
thadchais
changed the title
sunilhonest
changed the title
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
MXfive
approved these changes
Sep 25, 2024
olli-honest
approved these changes
Sep 25, 2024
thadchais
deleted the
thadchai/da-3815-add-retention-lock-to-gcs-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
Please confirm that you have done the following before requesting reviews:
Description
This PR introduces the following changes to the gcp_gcs_bucket module:
Retention Lock Configuration:
Added a retention_policy block to the google_storage_bucket resource to enable retention lock on the bucket.
Introduced two new variables: retention_lock_enabled and retention_lock_duration_seconds to control the retention lock settings.
Object Versioning:
Added a new variable: object_versioning_enabled to control the versioning of objects in the bucket.
Why
Retention Lock: Ensures that objects in the bucket are protected from deletion for a specified period, enhancing data security and compliance with data retention policies.
Data Engineers use this feature to backup data platform and secure the archived data. Here is the design document
Object Versioning: Allows multiple versions of an object to be stored, enabling retrieval, restoration, or permanent deletion of specific versions of objects.
APPENDIX
The variable
var.object_versioning_enabledis a boolean variable that, when set totrue, enables versioning for the Google Cloud Storage bucket. This means that multiple versions of an object can be stored in the bucket, allowing you to retrieve, restore, or permanently delete specific versions of objects.Mutually Exclusive with Retention Lock
The
retention_policyblock, which includes theretention_lock_enabledandretention_lock_duration_secondsvariables, is used to enforce a retention lock on the bucket. This lock ensures that objects cannot be deleted or replaced for a specified period.However, the
retention_policyand object versioning are mutually exclusive. This means you cannot enable both at the same time for a single bucket. Ifretention_lock_enabledis set totrue, you cannot enableobject_versioning_enabled, and vice versa. This restriction is in place because the retention policy enforces strict deletion rules that conflict with the flexibility provided by object versioning.More detail: Considerations with other features
Completed DA-3820 fixed Terratest workflow
This change is