Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyboard shortcut for #819 #822

Closed
jewel-andraia opened this issue Mar 9, 2014 · 4 comments
Closed

add keyboard shortcut for #819 #822

jewel-andraia opened this issue Mar 9, 2014 · 4 comments

Comments

@jewel-andraia
Copy link
Collaborator

following up #819, keyboard shortcuts shift-[up/down/left/right] for moving the (first visible) image in current selection around

@gablank
Copy link
Contributor

gablank commented Mar 9, 2014

Working on this, but I'm not sure if I understand what you mean by first visible? Can there be more than one image showing for a particular submission?

@jewel-andraia
Copy link
Collaborator Author

Comments can have multiple images.

@gablank
Copy link
Contributor

gablank commented Mar 9, 2014

Yeah, I kind of figured that out, in a way.

So, I decided that the image with the highest percentage of its height inside the viewport is the one we move. It works fairly well, although I'm not used to navigating Reddit by keyboard so maybe someone who is should test it out.

@matheod
Copy link
Collaborator

matheod commented May 14, 2014

Fixed by #819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants