Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why are Flask dependencies installed on Django build? #144

Open
dotysan opened this issue Jun 2, 2023 · 4 comments
Open

why are Flask dependencies installed on Django build? #144

dotysan opened this issue Jun 2, 2023 · 4 comments
Assignees
@dotysan @subzero10
Labels
help wanted

Comments

@dotysan
Copy link
Contributor

dotysan commented Jun 2, 2023

Example Job

Or more specifically, why does this script blindly install Flask dependencies--and even Flask itself--when $FLASK_VERSION isn't set.
@subzero10
Copy link
Member

Hey @Kelvin4664, any thoughts on this?

@dotysan
Copy link
Contributor Author

dotysan commented Jun 4, 2023

I've simplified the script in this branch, and am having no issues with CI.

@subzero10 subzero10 mentioned this issue Jun 6, 2023
Closed
@subzero10 subzero10 self-assigned this Jun 6, 2023
@subzero10
Copy link
Member

@dotysan Can you please create PR from your branch to see what's been done and what's pending?
It seems that you are tackling a couple of open issues, let's see if can address them all with a single PR.

@dotysan
Copy link
Contributor Author

dotysan commented Jun 8, 2023

Done in fresh branch here #153. Take a peek and review!

@dotysan dotysan mentioned this issue Jun 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dotysan dotysan

@subzero10 subzero10

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify install_frameworks.sh script for tests honeybadger-io/honeybadger-python
2 participants
@dotysan @subzero10