Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cache misses? possible speed improvement #388

Merged
merged 13 commits into from
Feb 10, 2021

Conversation

KonnorRogers
Copy link
Collaborator

I noticed a lot of cache misses in the logs for GH-actions. Testing to see if this speeds up the test suite.

@andrewmcodes
Copy link

@ParamagicDev id recommend using the official setup ruby action - it has caching baked in 🚀

@KonnorRogers
Copy link
Collaborator Author

@andrewmcodes already done!

@KonnorRogers
Copy link
Collaborator Author

Probably gonna have to create another Gemfile for 6.1.

Rails 6.1 has ActiveSupport alpha which requires > Ruby 2.7.

@joshuap
Copy link
Member

joshuap commented Feb 10, 2021

Probably gonna have to create another Gemfile for 6.1.

Rails 6.1 has ActiveSupport alpha which requires > Ruby 2.7.

#386 has info about our Gemfile setup. 👍

@joshuap
Copy link
Member

joshuap commented Feb 10, 2021

y'all are the best, btw. @andrewmcodes @ParamagicDev

@KonnorRogers
Copy link
Collaborator Author

KonnorRogers commented Feb 10, 2021

I think it may have been because I was using 2.x.x instead of 2.x. Let me see if changing it works.

@andrewmcodes
Copy link

andrewmcodes commented Feb 10, 2021

All runs around ~35 seconds? You’re a beast @ParamagicDev

Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a big improvement to me. 💪 If GH Actions concurrency were perfect it would probably be in the 1 minute target? Definitely good for the number of builds in the matrix (which we may be able to reduce, btw—it's been a while since we revisited the tests themselves).

Also, this is a big general upgrade to the actions workflow. 💯

@KonnorRogers
Copy link
Collaborator Author

@andrewmcodes its still around 2 mins. But the bundle installs are down around 4 seconds for a cached gemfile.

Cached bundle install

Screen Shot 2021-02-10 at 2 13 46 PM

Full run time

Screen Shot 2021-02-10 at 2 15 27 PM

So now with caching out of the way, perhaps we can press forward and look at whats actually slow! Perhaps we could parallelize some tests if maybe one test is holding everything up, etc. But this is a good step forward.

Summary of changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants