Use thor capture instead of full run_command from aruba.
#401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuap
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Looks good to me. On my machine, rake spec:features runs about 30% faster on this branch vs. on master (standalone). The specs that have been updated to test Thor in-process are definitely a lot faster! Maybe we can figure out a way to convert more specs in the future. This is a good foothold for now. 👍
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this isnt as full sweeping as I would have liked. Ideally I would have liked to rip out Aruba, but life is all about moderation. This will at least cut down on a decent number of
run_command's and should show at least a little improvement in speed. Let me know if you have any questions or comments!I left the
installandnotifyspecs alone as they were quite...thorny...when attempting to refactor them, Aruba appears to do a lot of isolation for us.