fix: do not check for rails console #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Rails applications may have Rails::Console defined (possibly through gems). This would inadvertantly disable Insights in production. The issue with this is that this will enable Insights in legitimate consoles, so we'll need to document how to disable it via ENV variables perhaps.
roelbondoc
commented
Jun 28, 2024
| @@ -71,16 +71,18 @@ def self.source_ignored?(source) | |||
| end | |||
|
|
|||
| Plugin.register :rails do | |||
| requirement { config.load_plugin_insights?(:rails_metrics) && defined?(::Rails.application) && ::Rails.application } | |||
There was a problem hiding this comment.
This should have been :rails and not :rails_metrics, but this is more of a naming thing and wouldn't have broken anything.
roelbondoc
commented
Jun 28, 2024
| ::ActiveSupport::Notifications.subscribe("sql.active_record", Honeybadger::ActiveRecordSubscriber.new) | ||
| ::ActiveSupport::Notifications.subscribe("process.action_mailer", Honeybadger::ActionMailerSubscriber.new) | ||
| ::ActiveSupport::Notifications.subscribe(/(service_upload|service_download)\.active_storage/, Honeybadger::ActiveStorageSubscriber.new) | ||
| if config.load_plugin_insights?(:rails) |
There was a problem hiding this comment.
cleanup: making the check here instead
roelbondoc
commented
Jun 28, 2024
| @@ -277,7 +277,6 @@ def load_plugin?(name) | |||
| end | |||
|
|
|||
| def insights_enabled? | |||
| return false if defined?(::Rails.application) && ::Rails.const_defined?("Console") | |||
There was a problem hiding this comment.
::Rails.const_defined?("Console") was always a bit finnicky to me to determine if we are in a console or not. I'm opting to just remove it for now until there is a better way to detect it automatically.
stympy
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Rails applications may have Rails::Console defined (possibly through gems). This would inadvertantly disable Insights in production. The issue with this is that this will enable Insights in legitimate consoles, so we'll need to document how to disable it via ENV variables perhaps.
Disable Insights when starting a Rails console:
Before submitting a pull request, please make sure the following is done:
rake specin the repository root.