Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of testing package causes testing flags to be registered #20

Closed
vcabbage opened this issue Jan 25, 2018 · 2 comments
Closed

Import of testing package causes testing flags to be registered #20

vcabbage opened this issue Jan 25, 2018 · 2 comments

Comments

@vcabbage
Copy link
Contributor

When the testing package is imported it registers a number of global flags (golang/go#21051). Since the test_helpers.go file in this project imports testing, any project that imports this library will get those flags.

Can test_helpers.go be renamed to have the _test.go suffix, helpers_test.go for example, so that it will be excluded from compilation when not running tests?

Thank you.

@christineyen
Copy link
Member

Hi! Thanks for the report, hoping to get a fix out for this soon.

@adihoney
Copy link
Contributor

adihoney commented Feb 6, 2018

This should be resolved in 1.6.0: https://github.com/honeycombio/libhoney-go/releases/tag/v1.6.0

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants