[create-hono] Make the app name change based on a project name

[yusukebe]

What is the feature you are proposing?

Currently, the application name of a project created by create-hono is fixed as my-app. This is bad for DX as we can only use a fixed name. Therefore, we need to modify create-hono so that the application name is based on the directory name.

[sor4chi]

Hi, @yusukebe
Does that mean that all the parts inside of the template app that are my-app should be dynamic?

eg. wrangler.toml in "cloudflare-workers" template

[sor4chi]

As for the directory name, like this video

Unspecified -> asking (default is my-app)
specified -> folder name (.)

How about this?

2023-10-12.23.08.16.mov

[yusukebe]

Hi @sor4chi,

Super cool! I love it.

[yusukebe]

Does that mean that all the parts inside of the template app that are my-app should be dynamic?

Ideally, yes. But actually, we don't do that.

As you mentioned, the name field in wrangler.toml should be dynamic:

https://github.com/honojs/starter/blob/main/templates/cloudflare-workers/wrangler.toml#L1

Alternatively, we could make the name field in package.json dynamic. However, since Deno has no config files, we don't apply that to all templates.

Anyway, I think we should make it flexible.

[sor4chi]

Okay. In my plan,

Create a REPLACE_FILE_LIST and put some paths like . /package.json or . /wrangler.toml.

I would like to set [DYNAMIC_APP_NAME] for the part of my-app and try to replace [DYNAMIC_APP_NAME] in REPLACE_FILE_LIST.

What do you think?

[yusukebe]

Using "magic strings" like [DYNAMIC_APP_NAME] is good!

I think we can make a "hook". The hook will be fired after clone. The following is pseudo code:

type Hook = (args: { projectName: string; templateName: string; directoryPath: string }) => void

const cloudflareWorkersHook:Hook = (arg) => {
  if (arg.templateName !== 'cloudflare-workers') return
  const wranglerTomlPath = getWranglerTomlPath(arg.directoryPath)
  rewriteNameInWranglerToml(wranglerTomlPath, arg.projectName)
}

[yusukebe]

And one more thing we need to consider is testing. There are no tests in the project currently, but we need them.

[yusukebe]

Or like the following:

type Hook = (args: { projectName: string; directoryPath: string }) => void;

const rewriteWranglerHook: Hook = () => {}

addHook('cloudflare-worker', rewriteWranglerHook)

[sor4chi]

wow, nice idea! I will get on with it for now!

[yusukebe]

This can be closed! Thanks @sor4chi !