AWS Lambda Adapter only keeps requestContext from API GW event and loses the rest

[dbain-texada]

What version of Hono are you using?

3.8

What runtime/platform is your app running on?

NodeJS

What steps can reproduce the bug?

I've deployed my hono app to AWS lambda, however, it seems we lose the cookies from the request. I'm looking at this file: https://github.com/honojs/hono/blob/main/src/adapter/aws-lambda/handler.ts. Comparing a log of a lambda using hono vs log of a regular lambda, my hono lambda only has the requestContext while the regular lambda has the entire API GW event. Why doesn't the adapter retain the cookies?

What is the expected behavior?

I want hono context to retain more info from the API GW event rather than just the requestContext. What is the purpose of stripping this info?

What do you see instead?

Only the requestContext remains on the hono context after using the aws-lambda hono adapter

Additional information

No response

[yusukebe]

cc: @watany-dev

[watany-dev]

As you pointed out, APIGatewayProxyEventV2 and other events are not capturing the complete event.
https://docs.aws.amazon.com/ja_jp/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html

@yusukebe
Should we address this by transcribing everything using this repository as a reference? I can handle it if it's from next week onward.
https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/aws-lambda

[yusukebe]

@watany-dev

Should we address this by transcribing everything using this repository as a reference? I can handle it if it's from next week onward.

Is that a lot of it?

[watany-dev]

@yusukebe

Actually, if it is just the cookie in this case, this PR will fix it.

#1613

I don't know how much to port all the lambda event interfaces, but it might not be that much, so I'll try to make a PR somewhere.

[yusukebe]

@watany-dev

I see!

Once things are done, I'll merge #1613 into main. And if you can, please create the PR to port all Lambda event interfaces. Thanks!

[dbain-texada]

That's awesome, thank you both for your inputs!

[watany-dev]

@yusukebe
I think this issue should be closed. What do you think?

[yusukebe]

Yeah, we can close it!