File to Blob

[yusukebe]

What is the feature you are proposing?

This is not a bug or a new big feature but a minor change that will be fix.

As @nakasyou said in this comment, FormData can accept Blob object as a value. It's better than File, that subclass of Blob. We have to replace File to Blob.

[EdamAme-x]

hmm..

As @nakasyou said, File extends Blob

playground

But, Node.js is using string | File.
So I think current types is better.

https://github.com/nodejs/node/blob/b4e8f1b6bb3616ba222c4513218aa1fa9d543d8e/deps/undici/src/types/formdata.d.ts#L10

[EdamAme-x]

According to this jsdoc, if a Blob object is passed to formData, it will be a File object named blob.

@param value The field's value. This can be [`Blob`](https://developer.mozilla.org/en-US/docs/Web/API/Blob)
    or [`File`](https://developer.mozilla.org/en-US/docs/Web/API/File). If none of these are specified the value is converted to a string.
@param fileName The filename reported to the server, when a Blob or File is passed as the second parameter. The default filename for Blob objects is "blob". The default filename for File objects is the file's filename.

[nakasyou]

@EdamAme-x, it's a used in output only.
In your URL, get receives unknown, and it says that get can receive Blob.¹

FormValue in Hono is for input, so we should change it.

Footnotes

1. https://github.com/nodejs/node/blob/b4e8f1b6bb3616ba222c4513218aa1fa9d543d8e/deps/undici/src/types/formdata.d.ts#L39 ↩

[EdamAme-x]

Thanks for reply @nakasyou

FormValue in Hono is for input

Can you elaborate on this part?

After parsing, I think it appears to be treated as just a Record object. ¹
I think this type is Record<string, string | File | string[] | File[]>.

Footnotes

1. https://github.com/honojs/hono/blob/ec58511247d7b9c33fff92ea992c127c6363eec0/src/validator/validator.ts#L114 ↩

[nakasyou]

@EdamAme-x

Can you elaborate on this part?

Client uses ValidationTargets as input.
BodyData can receive Blob, so client should receive Blob

[EdamAme-x]

Thanks @nakasyou
I think this requires a change of type between Client and Server.
I'll create PullRequest about this.

[fzn0x]

I've been using Hono with Bun in production apps, and I'm using just Blob to upload files! so I think it is necessary to do this changes 🚀