Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming route folder as "app" breaks nested router #239

Closed
bostjanpisler opened this issue Nov 30, 2024 · 3 comments · Fixed by #251
Closed

Naming route folder as "app" breaks nested router #239

bostjanpisler opened this issue Nov 30, 2024 · 3 comments · Fixed by #251
Labels
bug Something isn't working

Comments

@bostjanpisler
Copy link

What version of HonoX are you using?

0.1.27

What steps can reproduce the bug?

  1. Deploy hono create x-basic
  2. Create nested routes with index files /app and /app/nested
  3. Open /app/nested in browser

What is the expected behavior?

Page for /app/nested/index.tsx to be rendered

What do you see instead?

404 not found page

Additional information

No response
@bostjanpisler bostjanpisler added the bug Something isn't working label Nov 30, 2024
@bostjanpisler bostjanpisler changed the title Naming route folder app breaks nested router Naming route folder as "app" breaks nested router Nov 30, 2024
@yusukebe
Copy link
Member

yusukebe commented Dec 2, 2024

Hi @bostjanpisler

I think you should access /nested instead of /app/nested.

@bostjanpisler
Copy link
Author

bostjanpisler commented Dec 2, 2024 •
edited
Loading

I added folders /app/nested inside /routes, expecting localhost/app/nested to resolve:

Screenshot 2024-12-02 at 09 02 27

@yusukebe yusukebe mentioned this issue Jan 10, 2025
Merged
@yusukebe
Copy link
Member

Hi @bostjanpisler

This is fixed with the latest version v0.1.31. Please try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exclude /^\/app\/.+\.tsx?/ in vite dev-server honojs/honox
2 participants
@yusukebe @bostjanpisler