Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an alumni section to the contribute page #238

Open
1 of 9 tasks
jennwrites opened this issue Mar 2, 2016 · 13 comments
Open
1 of 9 tasks

Add an alumni section to the contribute page #238

jennwrites opened this issue Mar 2, 2016 · 13 comments

Comments

@jennwrites
Copy link
Contributor

jennwrites commented Mar 2, 2016

Part of #234

:octocat: Starter Issue

We would like to take the opportunity to invite someone who did not yet contribute to Hoodie to work on this issue. Follow @YourFirstPR on Twitter for more of these issues across many open source projects ☺️


💻 The Task

In preparation for the Camp Release we are trying to update the hood.ie site. This specific task involves updating the Hoodie community page to reflect our current contributors list. 🐶

  • Claimed (@May-8)
  • Go to the Community Page
  • Where the code is displayed (below a grey field) click on the pencil icon to the very right of the screen.
    screen shot 2016-02-23 at 17 50 39
  • Make your changes in the text field.
    • Create an alumni section between COMMUNITY and CONTRIBUTORS
    • Move the following folks to this section: Lena, Jan-Erik, Caolan, Katrin, Sven, Julia Schmidt
  • Describe your edits briefly under where it says Commit changes.
    Commit changes
  • Select the option to create a patch or a branch to begin the Pull Request process.
  • You are done 👏 comment below that your pull request is ready for review 🎉

Ping us in the Hoodie Chat or on Twitter if you have any questions :)

@gr2m
Copy link
Member

gr2m commented Mar 2, 2016

💡 idea:
maybe we could add paragraph to each alumni describing what they contributed to Hoodie?

@varjmes
Copy link
Contributor

varjmes commented Mar 5, 2016

maybe we could add paragraph to each alumni describing what they contributed to Hoodie?

Maybe we do this issue first, and then create a separate issue for CONTENT in the editorial repo? Because I think this can be done by someone who doesn't necessarily like writing :)

@gr2m
Copy link
Member

gr2m commented Mar 5, 2016

Agree :)

@sxosxo
Copy link
Contributor

sxosxo commented Mar 30, 2016

Hi! I'm happy to take this one.

@finnp
Copy link
Member

finnp commented Mar 30, 2016

@SonjaHeinen Great :) I've updated the post to show that you are working on this. Let us know if you have any questions!

@sxosxo
Copy link
Contributor

sxosxo commented Mar 30, 2016

@finnp Thanks. Well, I'm pretty sure the code I just wrote is fine. However, I'm running into quite strange Github magic that makes the changes look like a brilliant mess. Not sure if I should submit anyway..?
Hope these screenshots explain my issue:

githubmagic

@finnp
Copy link
Member

finnp commented Mar 30, 2016

Hey @SonjaHeinen, this looked like a Wat to me too, but it's not a problem. It's just that GitHub detected the changes differently than you actually did. The end result is the same. If you delete lines 28 to 45, it is the same result as deleting 31 to 48. This is because the lines 28 to 30 are the same as 46 to 48. Do you understand what I mean? I'm typing this in mobile, so sorry if my explanation is a bit off.

So yes you can submit it anyway :)

@sxosxo
Copy link
Contributor

sxosxo commented Mar 30, 2016

@finnp Yeah. I figured that's what happened. In that case, I'm curious how the code review turns out ;-)

@gr2m
Copy link
Member

gr2m commented May 12, 2016

@SonjaHeinen hey Sonja, did you submit a pull request? Do you need any help to finish things up?

@sxosxo
Copy link
Contributor

sxosxo commented May 12, 2016

@gr2m Thought I made a pull request weeks ago o_0
Currently, not sure where the code went...

@gr2m
Copy link
Member

gr2m commented May 12, 2016

@SonjaHeinen it’s here: https://github.com/SonjaHeinen/hood.ie/tree/patch-1

I think you missed to click the "Start Pull Request" button at the end, it’s a bit confusing, I miss that too at times

@May-8
Copy link

May-8 commented Feb 24, 2017

I would like to work on this.

@gr2m
Copy link
Member

gr2m commented Feb 25, 2017

okay all yours :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants