|
| 1 | +package destregistry_test |
| 2 | + |
| 3 | +import ( |
| 4 | + "io" |
| 5 | + "net/http" |
| 6 | + "net/http/httptest" |
| 7 | + "testing" |
| 8 | + |
| 9 | + "github.com/hookdeck/outpost/internal/destregistry" |
| 10 | + "github.com/stretchr/testify/assert" |
| 11 | + "github.com/stretchr/testify/require" |
| 12 | +) |
| 13 | + |
| 14 | +func TestMakeHTTPClient_UserAgent(t *testing.T) { |
| 15 | + t.Parallel() |
| 16 | + |
| 17 | + provider, err := newMockProvider() |
| 18 | + require.NoError(t, err) |
| 19 | + |
| 20 | + t.Run("sets user agent on requests", func(t *testing.T) { |
| 21 | + t.Parallel() |
| 22 | + |
| 23 | + // Create a test server that captures the User-Agent header |
| 24 | + var capturedUserAgent string |
| 25 | + server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
| 26 | + capturedUserAgent = r.Header.Get("User-Agent") |
| 27 | + w.WriteHeader(http.StatusOK) |
| 28 | + })) |
| 29 | + defer server.Close() |
| 30 | + |
| 31 | + // Create client with user agent |
| 32 | + userAgent := "TestAgent/1.0" |
| 33 | + client, err := provider.MakeHTTPClient(destregistry.HTTPClientConfig{ |
| 34 | + UserAgent: &userAgent, |
| 35 | + }) |
| 36 | + require.NoError(t, err) |
| 37 | + |
| 38 | + // Make a request |
| 39 | + resp, err := client.Get(server.URL) |
| 40 | + require.NoError(t, err) |
| 41 | + defer resp.Body.Close() |
| 42 | + io.ReadAll(resp.Body) |
| 43 | + |
| 44 | + // Verify user agent was set |
| 45 | + assert.Equal(t, "TestAgent/1.0", capturedUserAgent) |
| 46 | + }) |
| 47 | + |
| 48 | + t.Run("handles empty user agent string", func(t *testing.T) { |
| 49 | + t.Parallel() |
| 50 | + |
| 51 | + emptyUserAgent := "" |
| 52 | + client, err := provider.MakeHTTPClient(destregistry.HTTPClientConfig{ |
| 53 | + UserAgent: &emptyUserAgent, |
| 54 | + }) |
| 55 | + require.NoError(t, err) |
| 56 | + |
| 57 | + // Should still create a valid client |
| 58 | + assert.NotNil(t, client) |
| 59 | + assert.NotNil(t, client.Transport) |
| 60 | + }) |
| 61 | +} |
| 62 | + |
| 63 | +func TestMakeHTTPClient_Proxy(t *testing.T) { |
| 64 | + t.Parallel() |
| 65 | + |
| 66 | + provider, err := newMockProvider() |
| 67 | + require.NoError(t, err) |
| 68 | + |
| 69 | + t.Run("routes requests through proxy", func(t *testing.T) { |
| 70 | + t.Parallel() |
| 71 | + |
| 72 | + // Create a proxy server that tracks requests |
| 73 | + var proxyRequestReceived bool |
| 74 | + proxyServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
| 75 | + proxyRequestReceived = true |
| 76 | + // For CONNECT requests (HTTPS), respond with 200 |
| 77 | + if r.Method == http.MethodConnect { |
| 78 | + w.WriteHeader(http.StatusOK) |
| 79 | + return |
| 80 | + } |
| 81 | + // For regular HTTP requests, proxy them |
| 82 | + w.WriteHeader(http.StatusOK) |
| 83 | + })) |
| 84 | + defer proxyServer.Close() |
| 85 | + |
| 86 | + // Create a target server |
| 87 | + targetServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
| 88 | + w.WriteHeader(http.StatusOK) |
| 89 | + })) |
| 90 | + defer targetServer.Close() |
| 91 | + |
| 92 | + // Create client with proxy configured |
| 93 | + client, err := provider.MakeHTTPClient(destregistry.HTTPClientConfig{ |
| 94 | + ProxyURL: &proxyServer.URL, |
| 95 | + }) |
| 96 | + require.NoError(t, err) |
| 97 | + |
| 98 | + // Make a request through the proxy |
| 99 | + resp, err := client.Get(targetServer.URL) |
| 100 | + require.NoError(t, err) |
| 101 | + defer resp.Body.Close() |
| 102 | + io.ReadAll(resp.Body) |
| 103 | + |
| 104 | + // Verify request went through proxy |
| 105 | + assert.True(t, proxyRequestReceived, "Expected request to go through proxy") |
| 106 | + }) |
| 107 | + |
| 108 | + t.Run("returns error for invalid proxy URL", func(t *testing.T) { |
| 109 | + t.Parallel() |
| 110 | + |
| 111 | + invalidProxy := "://invalid-url" |
| 112 | + _, err := provider.MakeHTTPClient(destregistry.HTTPClientConfig{ |
| 113 | + ProxyURL: &invalidProxy, |
| 114 | + }) |
| 115 | + |
| 116 | + // Should return error for invalid proxy URL |
| 117 | + require.Error(t, err) |
| 118 | + assert.Contains(t, err.Error(), "invalid proxy URL") |
| 119 | + }) |
| 120 | +} |
0 commit comments