feat: multiple actions support and api improvements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
approved these changes
May 28, 2024
Comment on lines
+294
to
+296
| setTimeout(() => { | ||
| emit('removeToast', props.toast) | ||
| }, TIME_BEFORE_UNMOUNT) |
There was a problem hiding this comment.
It'll be good to obtain a reference to the timeout ID returned by the inner setTimeout call and clear it during the unmount phase.
| setTimeout(() => { | ||
| emit('removeToast', props.toast) | ||
| }, TIME_BEFORE_UNMOUNT) | ||
| return timeoutId |
There was a problem hiding this comment.
We need not return the timeoutID since it's available in the global scope and consumed in the unmount life cycle hook.
Comment on lines
+211
to
+216
| action: { | ||
| label: 'Confirm', | ||
| onClick: () => { | ||
| toast.dismiss() | ||
| } | ||
| } |
There was a problem hiding this comment.
Referring to the toast instance from the onClick callback here can prevent closing other toasts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple actions.
Example:
Added new callback parameter in
onClickfunction which through we can now pass thedeleteToastfunction. And call it if it's needed. The function acceptsdelayas parameter to delete the toast.