[WIP] ISSUE-1340 Upgrade jackson and relevant dependencies (directly and indirectly) #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since it touches various dependencies we may not feel safe to just rely on unit test. We may need to step back and not rush it... Which tests should we perform before merge this? If we feel safe to rely on system tests we need to merge so we have contradiction here. |
HeartSaVioR
commented
Mar 7, 2019
pom.xml
Outdated
| <!-- Ideally we need to use official version of SR: wait for new release --> | ||
| <schema-registry.version>0.6.0.3.4.0.0-145</schema-registry.version> | ||
| <!-- This version should be changed to actual HDF-3.4.0.0-146 version when it is published --> | ||
| <schema-registry.version>0.6.1-SNAPSHOT-HDF-3.4.0.0-146-maybe</schema-registry.version> |
There was a problem hiding this comment.
Should be changed to 3.4.0.0-146 (or higher) or new official SR version.
There was a problem hiding this comment.
Agree to keep the HDF version until the new SR version is pushed.
pom.xml
Outdated
| <curator.version>2.11.0</curator.version> | ||
| <dropwizard.version>1.0.5</dropwizard.version> | ||
| <curator.version>4.0.1</curator.version> | ||
| <curator.test.version>2.12.0</curator.test.version> |
There was a problem hiding this comment.
is it ok to have different version just for test ?
There was a problem hiding this comment.
I picked it up from Registry project, but it doesn't look like needed for Streamline. Will remove.
…directly) This patch brings change of huge dependencies so should be tested thoughtfully. Change-Id: Ic02c92aeb302a79b68598f6e0e66f18165fd2b43
Change-Id: I924e9508aa70c0340785d2da9234d1769e7a7eb3
Change-Id: Ib16f1c70872ae6eed54649cefca5235f9fe2ce60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings change of huge dependencies so should be tested thoughtfully.
The build passed with custom build of SR, and I'll upgrade once the version is available in HWX repo. After that we can check whether the build passes in Travis CI.
This closes #1340