Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic embedding of iD in TM #1909

Closed
pantierra opened this issue Oct 9, 2019 · 6 comments
Closed

Basic embedding of iD in TM #1909

pantierra opened this issue Oct 9, 2019 · 6 comments

Comments

@pantierra
Copy link
Contributor

We want iD to become part of the Tasking Manager: #1358

In order to work on the integration two possible ways of embedding (possibly via an iframe) should be possible:

  • Embed main iD as an iFrame.
  • Create a packaged (maybe containerized) setup for a self-hosted iD.
@JorgeMartinezG
Copy link
Contributor

To update on this issue. I implemented a basic approach and would like some feedback:

  1. Cloned id repository locally and installed required modules and dependencies.
  2. Compiled id editor.
  3. Copied dist folder_.
  4. Served folder with python and an index.html file.

The main idea is to use id editor as static folder, just like swagger. Then, within TM, we can create a new route passing the project task as gpx

@willemarcel
Copy link
Contributor

We could evaluate it together with #1883

@JorgeMartinezG JorgeMartinezG self-assigned this Oct 14, 2019
@JorgeMartinezG
Copy link
Contributor

Update

The current work done has been pushed to: https://github.com/hotosm/tasking-manager/tree/feature/1909-id-embed

Notes

  • Id editor library is served with Flask. A new endpoint has been included which reads oauth parameters and renders a html template.
  • I included a quick fix to service-worker.js which enables to bypass server endpoints. Needs further review.
  • If an user is not logged in Tasking Manager, cannot access id editor endpoint

@pantierra pantierra added this to the 4.0 Release milestone Nov 7, 2019
@JorgeMartinezG JorgeMartinezG removed their assignment Nov 11, 2019
@pantierra
Copy link
Contributor Author

I know @willemarcel has started working on it. Assigning to him.

@pantierra
Copy link
Contributor Author

The counterpart on the iD side has been implemented (openstreetmap/iD#7333), we are good to continue here.

@pantierra
Copy link
Contributor Author

Wohooo, this is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants