Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastAPI migration testing of Validator's workflow #6729

Open
manjitapandey opened this issue Feb 4, 2025 · 7 comments
Open

FastAPI migration testing of Validator's workflow #6729

manjitapandey opened this issue Feb 4, 2025 · 7 comments
Labels
status: testing Does it really work or is it pretending to work?

Comments

@manjitapandey
Copy link

manjitapandey commented Feb 4, 2025

Go on Tasking Manager staging site: https://tasks-stage.hotosm.org/
Testing the Explore Projects Page:

  • Verify that project cards are displayed across different pages.
  • Confirm that the map next to each project card can be shown or hidden.
  • Apply filters and search for specific projects; confirm that results update as expected.
  • Download project data as a CSV file and confirm it downloads without issues.

Testing Project Details Page:

  • Click on any project card to open its Project Details page.
  • Check that you can both view and post project-specific questions and comments. Also check tagging the users and authors and confirm if they get the notifications.
  • Test marking projects as favourites by clicking on ‘mark as favourite’ on the bottom ribbon of the project details page. Also try removing the project from your favourite.
  • Confirm that similar projects and the contribution timeline are visible and accurate.
  • Click on the Contribute button at the bottom right corner and confirm that it takes you to the project’s Tasks page.

On the Tasks Page:

  • Users should be able to view project’s instructions.
  • Users should be able to view the Contributions on the contribution tab. Try applying the filters of the contribution tab and verify the filtered data is correct.
  • Verify that the status of tasks is visible and accurate when viewed on the map.
  • Confirm that you can access the history (Activities and comments) of individual tasks. Also verify that you can post comments on the specific task.

Validating a Task:

  • Lock a single mapped task for validation.
  • Lock multiple mapped tasks for validation.
  • Test stopping the validation process midway clicking on stop validation.
  • Try marking the tasks as both validated and invalidate and observe if the status is updated correctly on map through colours.
  • Try multiple tasks locking and validating one and invalidating others.
  • Try adding the comments on the task and confirm that it's posted and tagged.
  • Ensure the notification and email is sent to respective mappers about validation and invalidation of task.
  • Ensure that you are not able to validate projects where permission is restricted to only team members which you are not the part of.
  • Also confirm the error message is displayed trying to validate the task you mapped by yourself.
  • Confirm the state of task is changed to ready to validate while requesting for revalidation of already validated task. Also ensure the activity is captured in task history.
@petya-kangalova petya-kangalova added the status: testing Does it really work or is it pretending to work? label Feb 4, 2025
@adiatmad
Copy link

adiatmad commented Feb 6, 2025

  1. I can validate my mapped task, here. FYI, I have admin access.

Image

Also confirm the error message is displayed trying to validate the task you mapped by yourself.


@manjitapandey
Copy link
Author

You shouldn't be able to validate the task mapped by yourself unless you have super admin access. If you have super admin access on staging, then its expected behavior. Otherwise, it seems to be an issue.

@martien-176
Copy link

@manjitapandey and Dinar, with me, i cannot validate a self mapped task.

I am admin on the staging.

Image

@martien-176
Copy link

martien-176 commented Feb 7, 2025

I found an issue related to validation, but not in this test list.

In a validated task do "Opening editor -> iD Editor": the task opens in iD, but without task border.
"Opening editor -> JOSM": JOSM opens including task border.

I tested with Firefox and Chrome, Windows 10.

@martien-176
Copy link

Completed the validator workflow testing: all items okay.

@manjitapandey
Copy link
Author

manjitapandey commented Feb 10, 2025

I am admin on the staging.

Can you confirm you are a super admin or organization admin?

In a validated task do "Opening editor -> iD Editor": the task opens in iD, but without task border.
"Opening editor -> JOSM": JOSM opens including task border.

I tested with Firefox and Chrome, Windows 10.

I tried to reproduce it on same browser but couldn't replicate the behavior. I can see those pink task boundaries for both single task selection and multiple tasks selection. Can you retry again and provide some more info? Screenshot maybe

@adiatmad
Copy link

A validator in Slack HOTOSM here raised an interesting question about the confusion between the development and live servers: How can we ensure we’re working on the correct one?

I propose adding a banner or something else on the development server to make it clear. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: testing Does it really work or is it pretending to work?
Projects
None yet
Development

No branches or pull requests

4 participants