Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Shipment Total Check in Brokering Service for Order Shipgroups #4

Closed
dixitdeepak opened this issue Feb 8, 2024 · 3 comments · Fixed by #51
Closed

Implement Shipment Total Check in Brokering Service for Order Shipgroups #4

dixitdeepak opened this issue Feb 8, 2024 · 3 comments · Fixed by #51
Assignees

Comments

@dixitdeepak
Copy link
Contributor

dixitdeepak commented Feb 8, 2024

Enhance the Brokering Service to introduce a new check that evaluates the shipment total of order shipgroups against a predefined limit set at the product store level. This feature aims to conditionally broker or split order shipgroups based on their shipment totals, enhancing the order fulfillment process's flexibility and efficiency.

Brokering Service Enhancement:
Modify the Brokering Service to introduce logic that checks the shipment total of an order shipgroup against the configured limit.The shipment total limit check should only apply under specific conditions to maintain flexibility in order brokering and fulfillment.

Condition Handling:
Full Brokerage on Single Location: If an order shipgroup is fully brokered to a single location, bypass the shipment total check, allowing the shipgroup to proceed without splitting regardless of its total.
Splitting Shipgroups: Initiate the shipment total check only if there's an attempt to split the order shipgroup among multiple locations. This includes:

  • Evaluating each potential split or brokered location's item total against the allowed shipment total.
  • Proceeding with splitting the shipgroup only if all brokered locations' item totals are greater than or equal to the allowed shipment total.

Condition Failure Handling: If any one of the shipgroup items, when evaluated for splitting, does not meet the shipment total condition, do not broker or split the order shipgroup. Ensure the order processing logic can gracefully handle this scenario and provide appropriate feedback/logic for next steps (e.g., manual intervention, alternative brokering strategy).

@dixitdeepak dixitdeepak changed the title Add support for shipment threhold while brokering Implement Shipment Total Check in Brokering Service for Order Shipgroups Feb 8, 2024
@dixitdeepak dixitdeepak self-assigned this Feb 8, 2024
@dt2patel
Copy link
Contributor

https://docs.google.com/document/d/1SoQfc5wF5_Fu-9GIgawwbReW7I5qQ-iwK5qfgVG7Tro/edit#heading=h.2vxkom3q2egg

Linking related document. This is going to be needed soon in prod. Can we prioritize this?

@dixitdeepak
Copy link
Contributor Author

dixitdeepak commented Sep 16, 2024

Here is PR #51
Added Brokering Shipment Threshold Support

  • User can now configure a brokering shipment threshold at the routing rule level.
  • If the inventory allocation returns a single location for the ship group items, the shipment threshold check will be skipped.
  • If the inventory allocation returns multiple locations for the same ship group items, brokering will perform the threshold check.
  • If all the location items meet the threshold check, the ship group items will proceed with brokering.
  • If any of the location items fail the threshold check, the routing rule action will be triggerd if set, else next rule will be executed
  • In case of split allow, if there are some unfillable items exists , the system will perform the threshold check on the unfillable items as well, so all the location items along with unfillalbe items should meet the threshold criteria.

@dixitdeepak
Copy link
Contributor Author

Added following data for shipment threhold check:
<moqui.basic.Enumeration enumId="IFP_SHIP_THREHOLD" description="Shipment threshold check" sequenceNum="8" enumTypeId="INV_FILTER_PRM_TYPE" enumCode="shipmentThreshold"/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants