Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting the same timezone in the timezone modal results in extra API call #247

Closed
1 of 2 tasks
ymaheshwari1 opened this issue Oct 7, 2022 · 0 comments · Fixed by #265
Closed
1 of 2 tasks

Selecting the same timezone in the timezone modal results in extra API call #247

ymaheshwari1 opened this issue Oct 7, 2022 · 0 comments · Fixed by #265
Labels
bug Something isn't working hacktoberfest Good issue for Hacktoberfest event

Comments

@ymaheshwari1
Copy link
Contributor

Current behavior

When selecting the same timezone as the currently selected timezone in the timezone modal, the api call to set the timezone is being made, that is not needed.

Expected behavior

When selecting the same timezone the api call should not being made.

Steps to reproduce the issue

  • Login to the app
  • Go to settings page
  • Click Change button for changing the timezone
  • In the modal, search for the same timezone currently selected and select the timezone in the modal
  • See in the network tab that the api call is made, but actually the timezone is not changed as previous and current timezone are same.

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information

Login Credentials:

  • username: aaron.wagner
  • password: Aaron@123
@ymaheshwari1 ymaheshwari1 added bug Something isn't working hacktoberfest Good issue for Hacktoberfest event labels Oct 7, 2022
@ymaheshwari1 ymaheshwari1 moved this to 🏗 In progress in Digital Experience Platform Nov 1, 2022
@adityasharma7 adityasharma7 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Nov 4, 2022
Repository owner moved this from 👀 In review to ✅ Done in Digital Experience Platform Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Good issue for Hacktoberfest event
Projects
Archived in project
1 participant