Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Space Below Favourite Product Store Name on Login When No Shopify Shop is Linked #725

Open
Adameddy26 opened this issue Aug 23, 2024 · 1 comment
Assignees
Labels
bug Something isn't working hacktoberfest Good issue for Hacktoberfest event

Comments

@Adameddy26
Copy link

Adameddy26 commented Aug 23, 2024

Note

Also blank option is present in the eCommerce card dropdown on settings page.

Current behavior

An empty space is visible below the favourite product store name, causing potential confusion for users.

Expected behavior

If no Shopify shop is linked and no product store is marked as a favourite, instead of showing an empty space, a message should be displayed to notify the user of the situation. For example: "No shopify shop is configured for this product store"

Steps to reproduce the issue

Log in the users app and open the user details page.
Ensure no Shopify shop is linked with the selected favourite product store.
Open the job manager app and observe the issue.

Environment details

App version : v2.23.2
App environment : UAT

Additional information

Screenshot from 2024-08-23 14-59-24

@Adameddy26 Adameddy26 added the bug Something isn't working label Aug 23, 2024
@ymaheshwari1 ymaheshwari1 added the hacktoberfest Good issue for Hacktoberfest event label Sep 17, 2024
@ravilodhi ravilodhi moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Feb 27, 2025
@dt2patel
Copy link
Contributor

Remove additional space by only rendering element when shop value is greater than 0

@priyanshee1604 priyanshee1604 moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Mar 4, 2025
@priyanshee1604 priyanshee1604 moved this from 🏗 In progress to 📅 Planned in Digital Experience Platform Mar 4, 2025
@priyanshee1604 priyanshee1604 moved this from 📅 Planned to 🛑 On hold in Digital Experience Platform Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Good issue for Hacktoberfest event
Projects
Status: 🛑 On hold
Development

No branches or pull requests

4 participants