-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbo visit with replace action flashes elements - same-page with query params #53
Comments
What happens if you add the morphing tag to
|
@joemasilotti Thanks for the speedy reply! I just double-checked, and we have curl -s https://hotwire-native-issue-demo-ef14973e7c91.herokuapp.com/ | head -n 8 <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no">
<meta name="turbo-refresh-method" content="morph">
<meta name="turbo-refresh-scroll" content="preserve"> |
Ah, darn. Was hoping that would be the fix. One more idea, can you try the latest |
Oh, that's great that #50 has been merged. Since that also impacted us, we've been using the Unfortunately, concerning this issue it persists with the very latest Sanity check:
Testing on latest main: Simulator.Screen.Recording.-.iPhone.16.-.2024-12-04.at.16.57.01.mp4 |
Hey 👋
Thanks for creating and sharing such a brilliant project. My colleagues and I have had an absolute blast using it to make a native app at work.
We have encountered an issue very similar to hotwired/turbo-ios#136, and we're unsure how to circumvent it.
We have these three pages on our website:
We've added these in our native application like so:
Since we don't want Turbo to "advance" when the links are clicked, we've configured them via
data-turbo-action="replace"
.This prevents the page from advancing (to the right) but causes the screen to "flash".
To demonstrate the problem, I've set up a temporary fork of the turbo-native-demo, which should be accessible via:
I added a navigation menu with Features and What's New, also using
data-turbo-action="replace"
, and clicking between the navigation links causes the same flashing to occur.Simulator.Screen.Recording.-.iPhone.16.-.2024-12-04.at.13.35.14.mp4
I was wondering if this is expected behaviour or if you have any words of wisdom on how we can avoid this from happening.
Thanks very much.
The text was updated successfully, but these errors were encountered: