Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup multithreading #23

Closed
wwahammy opened this issue Apr 2, 2018 · 4 comments · Fixed by #255 or #256
Closed

Setup multithreading #23

wwahammy opened this issue Apr 2, 2018 · 4 comments · Fixed by #255 or #256

Comments

@wwahammy
Copy link
Member

wwahammy commented Apr 2, 2018

Puma and Rails both supports multithreading. That said, it's not set up in the current code. Additionally, it's not entirely clear that Houdini's code is actually threadsafe. Setting up multithreading may require the following tasks:

This would be best handled by someone with experience dealing with Rails and multithreading

@tttp
Copy link

tttp commented Apr 3, 2018

@EricSchultz is there a way to validate that houdini is threadsafe? what area/code you suspect being at risk?

@wwahammy
Copy link
Member Author

wwahammy commented Apr 4, 2018

I don't know that there's anything at major risk or really much risk. There are a number of places where I can sense that a race condition could happen. The real question is how high that risk is versus the benefit and how serious the race condition would be.

@wwahammy
Copy link
Member Author

wwahammy commented Apr 4, 2018

Ideally, of course, the race conditions would be eliminated but that requires some significant rework.

@wwahammy
Copy link
Member Author

wwahammy commented Apr 9, 2018

As for validating, there's no automatic way to do it that I know of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants