Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink to a dir causes an issue with pre-commit hook #92

Open
autarch opened this issue Feb 11, 2019 · 0 comments
Open

Symlink to a dir causes an issue with pre-commit hook #92

autarch opened this issue Feb 11, 2019 · 0 comments

Comments

@autarch
Copy link
Member

autarch commented Feb 11, 2019

The problem seems to be that the pre-commit hook passes in this symlink path directly to $tidyall->process_paths. Then in process_path we check if $path->is_dir which returns true, and we error out because the commit hook didn't set the recursive flag to true.

I'm not sure what the best fix is here. I think it might be to simply handle symlinks explicitly by following them, or maybe at least add that as an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant