You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Collectionand Idx are really great to have lots of statically checked stuff.
The transit model has a lot of links between the objects, and for the moment all those links are Strings.
I think navitia_model could be even better if those String ids were also typed.
For example the stop_area_id in the StopPoint could be a Identifier<StopArea> instead of a String.
We could then also remove the get_idx/get method in CollectionWithId<T> to take an &Identifier<T> instead of a &str.
We would also need to find a nice name for this identifier. I don't think we can use the obvious Id because it's already a Trait. Identifier ? Link ? TypedId ? TId ? any other thing ? another option would be to rename the Id trait (maybe to HasId ?)
What do you think ?
The text was updated successfully, but these errors were encountered:
The
Collection
andIdx
are really great to have lots of statically checked stuff.The transit model has a lot of links between the objects, and for the moment all those links are
String
s.I think
navitia_model
could be even better if thoseString
ids were also typed.For example the
stop_area_id
in theStopPoint
could be aIdentifier<StopArea>
instead of aString
.We could then also remove the
get_idx
/get
method inCollectionWithId<T>
to take an&Identifier<T>
instead of a&str
.We would also need to find a nice name for this identifier. I don't think we can use the obvious
Id
because it's already aTrait
.Identifier
?Link
?TypedId
?TId
? any other thing ? another option would be to rename theId
trait (maybe toHasId
?)What do you think ?
The text was updated successfully, but these errors were encountered: