fix: run w/ multiple ruby versions in CI to ensure compatibility (Gusto#232)

* ci: run w/ multiple ruby versions

* fix: remove param from appraisal step

* fix: more parameters changes

* fix: make sure params are passed to commands

* fix: set ruby version in bundle install for release step

* fix: whitespace?

* chore: update nokogiri dep

* chore: remove ruby version from cache key

* chore: update all the things

* chore: update gemfiles, ignore schema comments in tests

* fix: webrick issue

* chore: update bundler version

* fix: lock appraisal to commit ref to address an issue in ruby 3.2 in CI

* fix: exclude ruby-3.2 incompatible versions of graphql from being tested in CI

* chore: inline rubocop job

* chore: revert rubocop-rspec upgrade, small bump to rubocop version

Author: grxy

.circleci/config.yml

@@ -53,12 +53,23 @@ commands:
             - ./vendor/bundle
 
 jobs:
+  ruby-lint:
+    docker:
+      - image: cimg/ruby:3.2-node
+    environment:
+      BUNDLE_APP_CONFIG: .bundle
+    steps:
+      - checkout
+      - bundle-install
+      - run: bundle exec rubocop
   ruby-test:
     parameters:
       appraisal:
         type: string
+      ruby:
+        type: string
     docker:
-      - image: cimg/ruby:2.6.9-node
+      - image: cimg/ruby:<< parameters.ruby >>-node
     environment:
       BUNDLE_APP_CONFIG: .bundle
     steps:
@@ -73,8 +84,10 @@ jobs:
     parameters:
       appraisal:
         type: string
+      ruby:
+        type: string
     docker:
-      - image: cimg/ruby:2.6.9-node
+      - image: cimg/ruby:<< parameters.ruby >>-node
     environment:
       BUNDLE_APP_CONFIG: .bundle
     steps:
@@ -87,7 +100,7 @@ jobs:
       - run: yarn lint
   release:
     docker:
-      - image: cimg/ruby:2.6.9-node
+      - image: cimg/ruby:3.2-node
     environment:
       BUNDLE_APP_CONFIG: .bundle
     steps:
@@ -100,17 +113,33 @@ workflows:
   version: 2
   main:
     jobs:
-      - gusto/ruby-lint
+      - ruby-lint
       - ruby-test:
           matrix:
             parameters:
               appraisal: ['graphql-1.10', 'graphql-1.11', 'graphql-1.12', 'graphql-1.13', 'graphql-2.0']
+              ruby: ['3.0', '3.1', '3.2']
+            exclude:
+              - appraisal: 'graphql-1.10'
+                ruby: '3.2'
+              - appraisal: 'graphql-1.11'
+                ruby: '3.2'
+              - appraisal: 'graphql-1.12'
+                ruby: '3.2'
       - integration-tests:
           matrix:
             parameters:
               appraisal: ['graphql-1.10', 'graphql-1.11', 'graphql-1.12', 'graphql-1.13', 'graphql-2.0']
+              ruby: ['3.0', '3.1', '3.2']
+            exclude:
+              - appraisal: 'graphql-1.10'
+                ruby: '3.2'
+              - appraisal: 'graphql-1.11'
+                ruby: '3.2'
+              - appraisal: 'graphql-1.12'
+                ruby: '3.2'
       - release:
           requires:
-            - gusto/ruby-lint
+            - ruby-lint
             - ruby-test
             - integration-tests

.rubocop.yml

@@ -4,6 +4,7 @@ AllCops:
   TargetRubyVersion: 2.3
   DisplayCopNames: true
   Exclude:
+    - 'node_modules/**/*'
     - 'gemfiles/**/*'
     - 'vendor/**/*'
 

Gemfile

@@ -4,4 +4,6 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem 'graphql', '1.10.14'
+# Fixes an issue in ruby 3.2, remove when a new version is published
+gem 'appraisal', git: 'https://github.com/thoughtbot/appraisal', ref: 'ea2baff57bc7f9e5f9e7a648916c9ae536325116'
+gem 'graphql', '~> 2.0.0'

Gemfile.lock

@@ -1,3 +1,13 @@
+GIT
+  remote: https://github.com/thoughtbot/appraisal
+  revision: ea2baff57bc7f9e5f9e7a648916c9ae536325116
+  ref: ea2baff57bc7f9e5f9e7a648916c9ae536325116
+  specs:
+    appraisal (2.4.1)
+      bundler
+      rake
+      thor (>= 0.14.0)
+
 PATH
   remote: .
   specs:
@@ -8,88 +18,85 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (6.1.3)
-      actionview (= 6.1.3)
-      activesupport (= 6.1.3)
-      rack (~> 2.0, >= 2.0.9)
+    actionpack (7.0.4.3)
+      actionview (= 7.0.4.3)
+      activesupport (= 7.0.4.3)
+      rack (~> 2.0, >= 2.2.0)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actionview (6.1.3)
-      activesupport (= 6.1.3)
+    actionview (7.0.4.3)
+      activesupport (= 7.0.4.3)
       builder (~> 3.1)
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    activesupport (6.1.3)
+    activesupport (7.0.4.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
-    appraisal (2.3.0)
-      bundler
-      rake
-      thor (>= 0.14.0)
-    ast (2.4.0)
+    ast (2.4.2)
     builder (3.2.4)
-    byebug (11.0.1)
-    coderay (1.1.2)
-    concurrent-ruby (1.1.8)
+    byebug (11.1.3)
+    coderay (1.1.3)
+    concurrent-ruby (1.2.2)
     crass (1.0.6)
-    debase (0.2.4.1)
-      debase-ruby_core_source (>= 0.10.2)
-    debase-ruby_core_source (0.10.9)
-    diff-lcs (1.3)
-    erubi (1.9.0)
+    debase (0.2.5.beta2)
+      debase-ruby_core_source (>= 0.10.12)
+    debase-ruby_core_source (3.2.0)
+    diff-lcs (1.5.0)
+    erubi (1.12.0)
     google-protobuf (3.21.12)
-    google-protobuf (3.21.12-x86_64-darwin)
-    google-protobuf (3.21.12-x86_64-linux)
-    graphql (1.10.14)
-    i18n (1.8.5)
+    graphql (2.0.19)
+    i18n (1.12.0)
       concurrent-ruby (~> 1.0)
-    jaro_winkler (1.5.3)
-    loofah (2.18.0)
+    jaro_winkler (1.5.4)
+    loofah (2.19.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
-    method_source (0.9.2)
-    mini_portile2 (2.4.0)
-    minitest (5.14.2)
-    nokogiri (1.9.1)
-      mini_portile2 (~> 2.4.0)
-    parallel (1.17.0)
-    parser (2.6.3.0)
-      ast (~> 2.4.0)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.7.0)
+    method_source (1.0.0)
+    minitest (5.18.0)
+    nokogiri (1.14.2-arm64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.14.2-x86_64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.14.2-x86_64-linux)
+      racc (~> 1.4)
+    parallel (1.22.1)
+    parser (3.2.1.1)
+      ast (~> 2.4.1)
+    pry (0.14.2)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.10.1)
       byebug (~> 11.0)
-      pry (~> 0.10)
-    rack (2.2.3)
-    rack-test (1.1.0)
-      rack (>= 1.0, < 3)
+      pry (>= 0.13, < 0.15)
+    racc (1.6.2)
+    rack (2.2.6.4)
+    rack-test (2.1.0)
+      rack (>= 1.3)
     rails-dom-testing (2.0.3)
       activesupport (>= 4.2.0)
       nokogiri (>= 1.6)
-    rails-html-sanitizer (1.4.3)
-      loofah (~> 2.3)
-    rainbow (3.0.0)
-    rake (13.0.1)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.3)
+    rails-html-sanitizer (1.5.0)
+      loofah (~> 2.19, >= 2.19.1)
+    rainbow (3.1.1)
+    rake (13.0.6)
+    rspec (3.12.0)
+      rspec-core (~> 3.12.0)
+      rspec-expectations (~> 3.12.0)
+      rspec-mocks (~> 3.12.0)
+    rspec-core (3.12.1)
+      rspec-support (~> 3.12.0)
+    rspec-expectations (3.12.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
+      rspec-support (~> 3.12.0)
+    rspec-mocks (3.12.4)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.0)
-    rubocop (0.72.0)
+      rspec-support (~> 3.12.0)
+    rspec-support (3.12.0)
+    rubocop (0.75.1)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.6)
@@ -98,14 +105,14 @@ GEM
       unicode-display_width (>= 1.4.0, < 1.7)
     rubocop-rspec (1.33.0)
       rubocop (>= 0.60.0)
-    ruby-debug-ide (0.7.2)
+    ruby-debug-ide (0.7.3)
       rake (>= 0.8.1)
-    ruby-progressbar (1.10.1)
-    thor (1.0.1)
-    tzinfo (2.0.4)
+    ruby-progressbar (1.13.0)
+    thor (1.2.1)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (1.6.0)
-    zeitwerk (2.4.2)
+    unicode-display_width (1.6.1)
+    webrick (1.8.1)
 
 PLATFORMS
   arm64-darwin-21
@@ -118,16 +125,17 @@ PLATFORMS
 DEPENDENCIES
   actionpack
   apollo-federation!
-  appraisal
-  debase
-  graphql (= 1.10.14)
+  appraisal!
+  debase (= 0.2.5.beta2)
+  graphql (~> 2.0.0)
   pry-byebug
   rack
   rake
   rspec
-  rubocop (~> 0.72.0)
+  rubocop (~> 0.75.0)
   rubocop-rspec
   ruby-debug-ide
+  webrick
 
 BUNDLED WITH
-   2.4.8
+   2.4.9

apollo-federation.gemspec

@@ -32,12 +32,13 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'actionpack'
   spec.add_development_dependency 'appraisal'
-  spec.add_development_dependency 'debase'
+  spec.add_development_dependency 'debase', '0.2.5.beta2'
   spec.add_development_dependency 'pry-byebug'
   spec.add_development_dependency 'rack'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'rubocop', '~> 0.72.0'
+  spec.add_development_dependency 'rubocop', '~> 0.75.0'
   spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'ruby-debug-ide'
+  spec.add_development_dependency 'webrick'
 end

example/graphql_server.rb

@@ -34,7 +34,7 @@ def self.run(schema, options = {})
       end
     end.parse!
 
-    Rack::Handler::WEBrick.run(GraphQLServer.new(schema), handler_options) do
+    Rack::Handler::WEBrick.run(GraphQLServer.new(schema), **handler_options) do
       if test_mode
         $stdout.puts '_READY_'
         $stdout.flush