Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl1-to-ddl2: casing lost during conversion #2828

Closed
drealeed opened this issue Aug 30, 2018 · 3 comments
Closed

ddl1-to-ddl2: casing lost during conversion #2828

drealeed opened this issue Aug 30, 2018 · 3 comments

Comments

@drealeed
Copy link

It looks like the mappings are being all lowercased in upgrade.ts. This is causing dashboards not to show up due to the ddl mapping fields not matching the casing of the actual data.

ddl1cased.json.txt

@GordonSmith
Copy link
Member

@drealeed There are two scenarios here:

  1. We upgrade the DDL to v2, but leave the existing service alone (v1 hipie genrated).
  2. We upgrade the DDL to v2 and upgrade the service to one generated by Hipie 2.0?

How realistic are both the above?

@drealeed
Copy link
Author

From HIPIE and DSP-Next's perspective, #2 is the only one we'd be using.

DDL v1s will be upgraded to v2 before the service is regenerated for them. For dashboards, people will want to load an existing hipie-generated ddl1 which hipie will convert into ddl2 and load into dashy, then save, and then run. For side-effect dashboards in plugin, I have a process which converts them to a ddl2 dashboard so that when a plugin is included in a composition run, its ddl2 dashboard will be generated.

@GordonSmith
Copy link
Member

#2864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants