-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{cae} [intel-2015a] GATE-7.0, Geant4-9.6.p04, root-5.34.26, clhep-2.1.3.1 (REVIEW) #1439
Conversation
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Gate should be build using gate.py easyblock. Still, Jenkins want to fall back to ConfigureMake. Why? |
@hajgato: |
Oops... |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Jenkins approved |
Refer to this link for build results (access rights to CI server needed): |
@hajgato: this PR is quite big, so it's going to be a pain to get it tested/reviewed/merged... Are you up for submitting a test report for this? See https://github.com/hpcugent/easybuild/wiki/Review-process-for-contributions#automated-testing-of-easyconfigs-pull-requests |
@boegel: Sorry for that, It was not the intention. I had no idea that ROOT has so many dependencies. And I did not even included graphviz, that would be 15+ more deps. :( For some reason, I am not able to automatically upload gist from our machine using --upload-test-report, and actually I am not able to upload any gists at all (some ssh incompatibility error.) If you tell me I can upload manually the test reports. (Or alternatively, I can test it from my desktop) |
@boegel: Or should I cut this pr into parts? |
@hajgato: let's first see how painful this is, before we cut it into pieces, we can still do that later |
# build dir should not be in the source tree! | ||
preconfigopts = 'mkdir ../../2.1.3.1_bld && cd ../../2.1.3.1_bld &&' | ||
prebuildopts = 'cd ../../2.1.3.1_bld &&' | ||
preinstallopts = 'cd ../../2.1.3.1_bld &&' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't hardcode the version, and there's even no need to use the version at all?
just call the dir obj
, which is more-or-less a standard?
@boegel what about eudev? That provides the libudev. (needs kernel headers, though) see http://www.gentoo.org/proj/en/eudev/ |
Refer to this link for build results (access rights to CI server needed): |
Jenkins: test this please |
@hajgato: Jenkins/GitHub is confused about this, probably due to temporary issues with Jenkins at the time of the test can you sync this with develop to try and get Jenkins to give a green light? |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5553/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Test report by @boegel |
@hajgato: failed test report due to download failures, I'll handle them and submit a new test report |
Test report by @boegel |
ext_bldd = '../../builddir' | ||
preconfigopts = 'mkdir %s && cd %s &&' % (ext_bldd,ext_bldd) | ||
prebuildopts = 'cd %s &&' % ext_bldd | ||
preinstallopts = 'cd %s &&' % ext_bldd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMakeMake
(now) supports separate_build_dir = True
, so just use that?
@hajgato: some minor style remarks left, let's get this merged... Let me know if you're sick of tackling remarks on this one, I can take it from here if you want me to. :-) |
@boegel: all changes implemented |
lgtm |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5624/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
prebuildopts = 'CPATH="$EBROOTLIBDRM/include/libdrm" ' | ||
|
||
sanity_check_paths = { | ||
'files': ['lib/libGL.%s' % SHLIB.EXT, 'include/GL/glext.h', 'include/GL/gl_mangle.h', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/SHLIB.EXT/SHLIB_EXT/g
SHLIB.EXT -> SHLIB_EXT
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5626/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Test report by @boegel |
(finally) going in, thanks @hajgato! |
{cae} [intel-2015a] GATE-7.0, Geant4-9.6.p04, root-5.34.26, clhep-2.1.3.1 (REVIEW)
needs
easybuilders/easybuild-easyblocks#566