Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{vis}[intel-2016a] libX11 1.6.3 (REVIEW) #2549

Merged
merged 12 commits into from
Mar 1, 2016

Conversation

hajgato
Copy link
Collaborator

@hajgato hajgato commented Feb 23, 2016

The following packages were moved to builddeps:
xcb-proto, xextproto, inputproto, kbproto, and ibpthread-stubs

  • xcb-proto is one pkconfig file, a bunch of Python files and a couple of xml files.
  • xextproto is one pkconfig file, a bunch of header files, and a couple of xml files.
  • inputproto is one pkconfig file, and a couple of header files.
  • kbproto is one pkconfig file, a couple of header files, and a bunch of xml and svg files.
  • libpthread-stubs is one pkconfig file.

We have to check this new configuration on a completely X-less machine, and we have to check softwares depend on libX11, they might need (some of) the above modules as builddependencies.

Only xcp-proto depends on Python, and as it is now only a builddependency, libX11 is finally Python free!

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6515/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Feb 24, 2016

Test report by @boegel
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in this PR)
Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/3b5492eefafccf2bacab for a full test report.

@boegel
Copy link
Member

boegel commented Feb 24, 2016

Test report by @boegel
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/b39b4f05c21bc576209c for a full test report.

@boegel
Copy link
Member

boegel commented Feb 24, 2016

Looks good, but we need to check some more, I think...

This was on systems that have X11 stuff provided by the OS.

@rjeschmi
Copy link
Contributor

In file included from /export/easybuild/build/Tk/8.6.4/foss-2015b-no-X11/tk8.6.4/unix/../generic/tkPort.h:21:0,
                 from /export/easybuild/build/Tk/8.6.4/foss-2015b-no-X11/tk8.6.4/unix/../generic/tkInt.h:19,
                 from /export/easybuild/build/Tk/8.6.4/foss-2015b-no-X11/tk8.6.4/unix/../generic/tkStubLib.c:14:
/export/easybuild/build/Tk/8.6.4/foss-2015b-no-X11/tk8.6.4/unix/../generic/tk.h:96:25: fatal error: X11/Xlib.h: No such file or directory
 #   include <X11/Xlib.h>
                         ^
In file included from /export/easybuild/build/Tk/8.6.4/foss-2015b-no-X11/tk8.6.4/unix/../generic/ttk/ttkStubLib.c:9:0:
/export/easybuild/build/Tk/8.6.4/foss-2015b-no-X11/tk8.6.4/unix/../generic/tk.h:96:25: fatal error: X11/Xlib.h: No such file or directory
 #   include <X11/Xlib.h>
                         ^
compilation terminated.
compilation terminated.

The headers that are included in Tk are not being found here. I think we are missing a -I. I've fixed this before, but haven't merge it..

@rjeschmi
Copy link
Contributor

I realize that this isn't in this PR, but it is blocking me from testing it ..

@rjeschmi
Copy link
Contributor

I'll follow up here #2261

@rjeschmi
Copy link
Contributor

so the first deps works

== building and installing xcb-proto/1.11-foss-2015b-Python-2.7.11...

but

== processing EasyBuild easyconfig /tmp/eb-BQpQZZ/tweaked_easyconfigs/libxcb-1.11.1-foss-2015b.eb
== building and installing libxcb/1.11.1-foss-2015b...
== fetching files...
== creating build dir, resetting environment...
== unpacking...
== patching...
== preparing...
== configuring...
== FAILED: Installation ended unsuccessfully (build directory: /export/easybuild/build/libxcb/1.11.1/foss-2015b): build failed (first 300 chars): cmd " ./configure --prefix=/export/easybuild/software/libxcb/1.11.1-foss-2015b " exited with exitcode 1 and output:
checking for a BSD-compatible install... /bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gaw
== Results of the build can be found in the log file /tmp/eb-BQpQZZ/easybuild-libxcb-1.11.1-20160225.050320.bZwrl.log
ERROR: Build of /tmp/eb-BQpQZZ/tweaked_easyconfigs/libxcb-1.11.1-foss-2015b.eb failed (err: 'build failed (first 300 chars): cmd " ./configure --prefix=/export/easybuild/software/libxcb/1.11.1-foss-2015b " exited with exitcode 1 and output:\nchecking for a BSD-compatible install... /bin/install -c\nchecking whether build environment is sane... yes\nchecking for a thread-safe mkdir -p... /bin/mkdir -p\nchecking for gawk... gaw')
[root@299c3d2f763f ~]# less /tmp/eb-BQpQZZ/easybuild-libxcb-1.11.1-20160225.050320.bZwrl.log

checking if gcc -std=gnu99 supports -Werror=attributes... yes
Package xorg-macros was not found in the pkg-config search path.
Perhaps you should add the directory containing `xorg-macros.pc'
to the PKG_CONFIG_PATH environment variable
No package 'xorg-macros' found
checking whether make supports nested variables... (cached) yes
checking whether to build developer documentation... yes
checking for doxygen... no
configure: WARNING: doxygen not found - documentation targets will be skipped
configure: WARNING: dot not found - doxygen targets will be skipped
checking for CHECK... no
checking for XCBPROTO... yes
checking for NEEDED... no
configure: error: Package requirements (pthread-stubs xau >= 0.99.2) were not met:

Package xproto was not found in the pkg-config search path.
Perhaps you should add the directory containing `xproto.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xproto', required by 'Xau', not found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables NEEDED_CFLAGS
and NEEDED_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
 (at easybuild/tools/run.py:397 in parse_cmd_output)

@hajgato
Copy link
Collaborator Author

hajgato commented Feb 25, 2016

@rjeschmi add xproto as builddep for libxcb

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6576/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hajgato
Copy link
Collaborator Author

hajgato commented Feb 25, 2016

@rjeschmi @boegel Strange thing that for me libxcb found xproto, despite it was not dep or builddep.
maybe the solution is to make a big bundle for X and for X headers (proto's).

@boegel
Copy link
Member

boegel commented Feb 25, 2016

@hajgato: it found which xproto?

@hajgato
Copy link
Collaborator Author

hajgato commented Feb 25, 2016

@boegel: Ok, I might checked a wrong logfile.
Anyway, probably form system.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6584/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Feb 25, 2016

I'd like to see @rjeschmi test this again on a minimal system...

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6586/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@rjeschmi
Copy link
Contributor

Test report by @rjeschmi
SUCCESS
Build succeeded for 11 out of 11 (11 easyconfigs in this PR)
Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2676 v3 @ 2.40GHz, Python 2.7.5
See https://gist.github.com/f7b729e91bc18032f8cd for a full test report.

@rjeschmi
Copy link
Contributor

Looks good. Used the foss toolchain and removed Tk from Python, but otherwise good.

@boegel
Copy link
Member

boegel commented Feb 25, 2016

So, @hajgato, what do you reckon?

@hajgato
Copy link
Collaborator Author

hajgato commented Feb 26, 2016

@boegel: I did it, so we should merge it (if passes the checks). Anyway I am working on the "bundle" version as well. If you think it is better to use only the bundle, then we do not have to merge it.

@hajgato
Copy link
Collaborator Author

hajgato commented Feb 26, 2016

@boegel what happens with if a .py file is compiled to a read only .pyc and .pyo and we change the Python version? Will the .py run, or the .pyo/.pyc?

@hajgato
Copy link
Collaborator Author

hajgato commented Feb 26, 2016

@boegel xcb-proto installs the same .py files using Python-{2.6.6,2.7.11,3.5.1}, so I made a version using system Python and dummy toolchain.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6604/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6605/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6611/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.


sanity_check_paths = {
'files': ['lib/pkgconfig/xcb-proto.pc'],
'dirs': ['lib/python%s/site-packages/xcbgen' % pyshortver]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an issue...

if the system Python is updated from 2.6 to 2.7, this will not be found anymore?

besides, this is not in $PYTHONPATH anyway, as it is now (same issue when we include our own Python version)...

does that mean the Python bits are basically irrelevant?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe this is handled via the pkg-config file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel: this handled by the pkgconfig:
xcb-proto.pc:

prefix=/apps/brussel/ivybridge/software/xcb-proto/1.11
exec_prefix=${prefix}
datarootdir=${prefix}/share
datadir=${datarootdir}
libdir=${exec_prefix}/lib
xcbincludedir=${datadir}/xcb
pythondir=${prefix}/lib/python2.6/site-packages

Name: XCB Proto
Description: X protocol descriptions for XCB
Version: 1.11

I am more concerned what will happen with the precompiled pyo files if you change Python version. (especially, if they are read-only)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel:
xcb-proto has only python bits, so they cannot be irrelevant....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, not a problem indeed since it's handled by pkg-config


builddependencies = [
('xextproto', '7.3.0'),
('xcb-proto', '1.11', '-Python-2.7.11'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato: you missed updating this to use the dummy xcb-proto easyconfig?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel aarghhh.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6673/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6674/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6675/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

minor style fixes in X lib easyconfigs
@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6680/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Mar 1, 2016

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (11 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/7a96c98eb2d0cacf502e for a full test report.

@boegel
Copy link
Member

boegel commented Mar 1, 2016

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (11 easyconfigs in this PR)
Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/789b548413436665ca64 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 1, 2016

Going in, thanks @hajgato!

boegel added a commit that referenced this pull request Mar 1, 2016
{vis}[intel-2016b] libX11 1.6.3 (REVIEW)
@boegel boegel merged commit 407d859 into easybuilders:develop Mar 1, 2016
@boegel boegel changed the title {vis}[intel-2016b] libX11 1.6.3 (REVIEW) {vis}[intel-2016a] libX11 1.6.3 (REVIEW) Mar 16, 2016
@hajgato hajgato deleted the libx11-2016aa branch June 8, 2017 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants