use 'python -O' in 'eb' command (REVIEW) #1357

boegel · 2015-08-14T06:56:59Z

This is interesting because of significant performance improvements for (mainly) the logger via hpcugent/vsc-base#182, but needs to be evaluated carefully to make sure this doesn't break anything.

First step is to see whether all the unit tests still pass under python -O.

See also http://stackoverflow.com/questions/2055557/python-optimized-mode .

edit: now requires hpcugent/vsc-base#188

hpcugentbot · 2015-08-14T08:05:17Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1970/
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1970/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-08-20T10:50:45Z

TODO:

fix broken tests
add support for eb --test, to make sure unit tests are run exactly like eb is (e.g., with python -O)
update documentation on running unit tests

hpcugentbot · 2015-09-18T18:37:38Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2059/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-09-18T19:24:11Z

test/framework/build_log.py

@@ -65,7 +65,7 @@ def test_easybuilderror(self):
        self.assertErrorRegex(EasyBuildError, 'BOOM', raise_easybuilderror, 'BOOM')
        logToFile(tmplog, enable=False)

-        log_re = re.compile("^%s :: BOOM \(at .*:[0-9]+ in [a-z_]+\)$" % getRootLoggerName(), re.M)
+        log_re = re.compile("^%s :: BOOM( \(at .*:[0-9]+ in [a-z_]+\))?$" % getRootLoggerName(), re.M)


not sure how happy I am with this, since this basically indicates that the location where errors occur are no longer available...

@JensTimmerman: maybe you've been a little bit too eager with putting the if __debug__s in place?

I'll try and see if this can be restored by rolling back one of the if __debug__s without big impact on performance...

No I have not been to eager, the location is only visible in debug mode.
if you're not debugging then the location is of no interest to you.

hpcugentbot · 2015-09-18T19:46:51Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2063/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-09-18T20:29:46Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2065/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-09-18T20:32:07Z

Needs more work:

$ eb --test
== Running framework unit tests...

Running tests...
----------------------------------------------------------------------
.......................F...............................(skipping SvnRepository test)
.................................................................................................................................................................................................................................................................GC3Pie not available, skipping test
...........
======================================================================
ERROR [0.326s]: test_generate_cmd_line (test.framework.options.CommandLineOptionsTest)
Test for generate_cmd_line.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/kehoste/work/easybuild-framework/test/framework/options.py", line 1673, in test_generate_cmd_line
    self.assertEqual(ebopts.generate_cmd_line(), [])
AssertionError: Lists differ: ['--test'] != []

First list contains 1 additional elements.
First extra element 0:
--test

- ['--test']
+ []

----------------------------------------------------------------------
Ran 323 tests in 544.241s

FAILED (errors=1)

Generating XML reports...
ERROR: Not all tests were successful.
Log available at /var/folders/8s/_frgh9sj6m744mxt5w5lyztr0000gn/T/eb-59xoyb/eb-F68gCF/eb-9Vdxio/easybuild-tests-PSz63l.log , XML output of tests available in test-reports directory
ERROR: One or more tests failed!

hpcugentbot · 2015-09-18T21:11:39Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2066/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-09-18T21:53:27Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2067/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-09-19T10:35:05Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2068/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

…ython -O" This reverts commit 294a1d4.

hpcugentbot · 2015-09-19T14:56:48Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2069/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

boegel · 2015-09-19T14:57:16Z

Jenkins: test this please

hpcugentbot · 2015-09-19T15:07:11Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2070/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-29T21:03:15Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2268/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

wpoely86 · 2015-11-06T08:54:29Z

The -O is fine by me. But running the unit tests from the main program seems a bit weird to me? That's something that's usually clearly separated?

JensTimmerman · 2015-11-06T10:36:55Z

agreed, unit tests are not usually shipped with the packaged version of an application, and it's not something you would run a lot, only when developing, so I don't see a reason to add it, but now it's there, oh well.
However, --test is probably a bad option to specify, because to me this would imply you are going to test the build of the easyconfig you've given as argument.

the --test option doesn't seem to be an option at all, but more of an alternate argument?
so it becomes clear tha teb test has nothing to do with the options you give when you run
eb easyconfig.eb
and since an easyconfing can actually be called test already, maybe it would be less confusing and clear if you just ad a new eb-test command?

hpcugentbot · 2016-02-06T16:46:56Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2621/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-02-06T18:31:46Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2623/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-02-06T19:12:06Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2624/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2016-02-06T20:06:34Z

I removed the --test bit, since it wasn't allowing to run single tests, which is actually what I'm after...

@wpoely86: please (re)review?

This makes a major difference in terms of speed, I really want this merged ASAP.

wpoely86 · 2016-02-06T20:09:21Z

This all looks fairly trivial?

boegel · 2016-02-06T20:19:58Z

@wpoely86: yep, the only change needed to make the tests happy is the thing in build_log.

wpoely86 · 2016-02-06T20:49:15Z

lgtm

boegel · 2016-02-06T21:00:33Z

Thanks for the review @wpoely86!

use 'python -O' in 'eb' command & add support for running unit tests with eb --test (WIP)

use 'python -O' in 'eb' command

bad3678

boegel mentioned this pull request Sep 9, 2015

make EB installation as zipped eggs work #1369

Closed

boegel added 2 commits September 18, 2015 18:50

make strict test more flexible, so that it also works under python -O

294a1d4

implement --test

c3bdd01

boegel added this to the v2.4.0 milestone Sep 18, 2015

boegel added 2 commits September 18, 2015 21:05

minor tweaks

5b97d7a

Merge branch 'develop' into python_O

53b713c

boegel reviewed Sep 18, 2015
View reviewed changes

move run_unit_test_suite to easybuild.tools.testing

d5f703e

boegel added 2 commits September 18, 2015 21:58

fix imports

e8fd163

really fix imports

a01e536

boegel changed the title ~~use 'python -O' in 'eb' command~~ use 'python -O' in 'eb' command (WIP) Sep 18, 2015

clean up sys.argv in setUp for tests

0828230

boegel added 2 commits September 19, 2015 13:45

add support in --test for running subsuites

50fcf64

Revert "make strict test more flexible, so that it also works under p…

a6a0fb1

…ython -O" This reverts commit 294a1d4.

boegel mentioned this pull request Sep 19, 2015

support using 'inspect' when desired in LoggedException hpcugent/vsc-base#188

Merged

boegel added 2 commits September 19, 2015 14:14

enable 'include_location' in LoggedException

10ca758

enable INCLUDE_LOCATION in EasyBuildError, bump required vsc-base

62fbd3d

boegel modified the milestones: v2.5.0, v2.6.0 Dec 14, 2015

boegel modified the milestones: v2.6.0, v2.7.0 Jan 22, 2016

boegel added 2 commits January 27, 2016 15:28

Merge branch 'develop' into python_O

45b550c

Merge branch 'develop' into python_O

aa6f329

boegel added 3 commits February 6, 2016 18:37

add optimize=1 to setup.cfg

9493707

don't hardcode 'python -O', define $PYTHONOPTIMIZE instead

d817f9a

remove --test support

2f07fca

boegel mentioned this pull request Feb 6, 2016

EasyBuild 2.7.0 (roadmap) easybuilders/easybuild#192

Closed

17 tasks

boegel added a commit that referenced this pull request Feb 6, 2016

Merge pull request #1357 from boegel/python_O

7a9d431

use 'python -O' in 'eb' command & add support for running unit tests with eb --test (WIP)

boegel merged commit 7a9d431 into easybuilders:develop Feb 6, 2016

boegel deleted the python_O branch February 6, 2016 21:00

boegel mentioned this pull request Mar 3, 2016

enhance logging format: remove logger name, mention location instead #1649

Merged

boegel changed the title ~~use 'python -O' in 'eb' command & add support for running unit tests with eb --test (WIP)~~ use 'python -O' in 'eb' command (REVIEW) Mar 14, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use 'python -O' in 'eb' command (REVIEW) #1357

use 'python -O' in 'eb' command (REVIEW) #1357

boegel commented Aug 14, 2015

hpcugentbot commented Aug 14, 2015

boegel commented Aug 20, 2015

hpcugentbot commented Sep 18, 2015

boegel Sep 18, 2015

JensTimmerman Sep 21, 2015

hpcugentbot commented Sep 18, 2015

hpcugentbot commented Sep 18, 2015

boegel commented Sep 18, 2015

hpcugentbot commented Sep 18, 2015

hpcugentbot commented Sep 18, 2015

hpcugentbot commented Sep 19, 2015

hpcugentbot commented Sep 19, 2015

boegel commented Sep 19, 2015

hpcugentbot commented Sep 19, 2015

hpcugentbot commented Oct 29, 2015

wpoely86 commented Nov 6, 2015

JensTimmerman commented Nov 6, 2015

hpcugentbot commented Feb 6, 2016

hpcugentbot commented Feb 6, 2016

hpcugentbot commented Feb 6, 2016

boegel commented Feb 6, 2016

wpoely86 commented Feb 6, 2016

boegel commented Feb 6, 2016

wpoely86 commented Feb 6, 2016

boegel commented Feb 6, 2016

use 'python -O' in 'eb' command (REVIEW) #1357

use 'python -O' in 'eb' command (REVIEW) #1357

Conversation

boegel commented Aug 14, 2015

hpcugentbot commented Aug 14, 2015

boegel commented Aug 20, 2015

hpcugentbot commented Sep 18, 2015

boegel Sep 18, 2015

Choose a reason for hiding this comment

JensTimmerman Sep 21, 2015

Choose a reason for hiding this comment

hpcugentbot commented Sep 18, 2015

hpcugentbot commented Sep 18, 2015

boegel commented Sep 18, 2015

hpcugentbot commented Sep 18, 2015

hpcugentbot commented Sep 18, 2015

hpcugentbot commented Sep 19, 2015

hpcugentbot commented Sep 19, 2015

boegel commented Sep 19, 2015

hpcugentbot commented Sep 19, 2015

hpcugentbot commented Oct 29, 2015

wpoely86 commented Nov 6, 2015

JensTimmerman commented Nov 6, 2015

hpcugentbot commented Feb 6, 2016

hpcugentbot commented Feb 6, 2016

hpcugentbot commented Feb 6, 2016

boegel commented Feb 6, 2016

wpoely86 commented Feb 6, 2016

boegel commented Feb 6, 2016

wpoely86 commented Feb 6, 2016

boegel commented Feb 6, 2016