Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Position #612

Closed
benn02 opened this issue Jan 19, 2023 · 0 comments · Fixed by #625
Closed

Refactor Position #612

benn02 opened this issue Jan 19, 2023 · 0 comments · Fixed by #625
Assignees

Comments

@benn02
Copy link
Contributor

benn02 commented Jan 19, 2023

Currently, objects that can be on the map have a deprecated position property. Since objects don't have to be on the map, this property can then be undefined.
This is insufficient because some of these objects can have different positions that are off the map. Therefor, we have introduced the MetaPosition that encapsulates all sorts of positions on and off the map.
The MetaPosition is present where it is needed, but doesn't replace position in all classes.
This issue is about replacing position properties in all classes and get rid of all of its usage. Also get rid of the Position Class.
This is also about refactoring of associated Logic when the position is undefined and make things more explicit.
When all usage of position is gone, we could rename the MetaPosition to Position.

Requirement: M6b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant