Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make type properties distinctable #637

Closed
lukasrad02 opened this issue Feb 1, 2023 · 0 comments · Fixed by #642
Closed

Make type properties distinctable #637

lukasrad02 opened this issue Feb 1, 2023 · 0 comments · Fixed by #642
Assignees
@benn02
Labels
shared Issues mainly related to shared

Comments

@lukasrad02
Copy link
Contributor

#616 added a type property to elements that are part of the state. The string literals used in this PR overlap with the string literals for the types in shared/src/models/utils/start-points.ts.

Although there should not be a situation in which we have to differentiate between an element from #616 and a StartPoint from the file mentioned above, the type properties should be unique to avoid confusion.
@lukasrad02 lukasrad02 added the shared Issues mainly related to shared label Feb 1, 2023
@benn02 benn02 self-assigned this Feb 1, 2023
@benn02 benn02 mentioned this issue Feb 1, 2023
Merged
@benn02 benn02 linked a pull request Feb 1, 2023 that will close this issue
Refactor Start Point Literals #642
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benn02 benn02

Labels
shared Issues mainly related to shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Start Point Literals hpi-sam/digital-fuesim-manv
2 participants
@lukasrad02 @benn02