-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
在yaf中 使用hprose 当 return 字符串时 会产生警告 #59
Comments
$value 可能是类名,所以这里才会有这个判断。 不过好像这个判断确实有些多余,在类中定义一个 then 的静态方法作为一个类 Promise 对象来用,好像并没有什么用。 |
我也注意到了这点 说实话 Promise 异步编程这章 我没这么看懂.... |
我把你提交的代码已经合并了。 |
好的 多谢了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
我注意到是由于 Hprose\Future 中 100行~101行
if (($value !== NULL) and is_object($value) or is_string($value)) {
if (method_exists($value, 'then')) {
导致的
这是一个很棒的设计 但我觉得yaf 中的自动载入也是合理的
能否把 or is_string($value) 去掉
The text was updated successfully, but these errors were encountered: