Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tags #104

Open
SpiritQuaddicted opened this issue Aug 16, 2015 · 4 comments
Open

Support for tags #104

SpiritQuaddicted opened this issue Aug 16, 2015 · 4 comments

Comments

@SpiritQuaddicted
Copy link
Collaborator

Similarly to https://www.quaddicted.com/reviews/ the QI should list the tags and allow filtering. This will require the "API" at Quaddicted to serve them first.

@hrehfeld
Copy link
Owner

Check the xml parsing, I think you should just be able to add new tags into the map section. Adding to the api would be a first step. What are the allowed chars in tags? how do you save them in the db?

@hrehfeld
Copy link
Owner

Any progress on this?

@SpiritQuaddicted
Copy link
Collaborator Author

I could simply add a new element like this:

<tags>
  <tag>this</tag>
  <tag>is</tag>
  <tag>a</tag>
  <tag>tag</tag>
</tags>

I use /^[a-z0-9_\-, ]*$ to sanitize tags. The table has zipname&tag&username in each row. Usernames are not really used, I had other plans back then. Messy spaghetti ahead: https://github.com/SpiritQuaddicted/Quaddicted-reviews/blob/master/details.php#L67

@SpiritQuaddicted
Copy link
Collaborator Author

Tags are now included in the XML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants