Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.0 Cargo build error out of the box #21

Closed
CaptainIsaaca opened this issue Nov 20, 2022 · 4 comments
Closed

Version 3.0.0 Cargo build error out of the box #21

CaptainIsaaca opened this issue Nov 20, 2022 · 4 comments

Comments

@CaptainIsaaca
Copy link

CaptainIsaaca commented Nov 20, 2022

When upgraded the version to 3.0.0 cargo failed to build throwing internal error as follows:
--> C:\Users\Name\\.cargo\registry\src\github.com-1ecc6299db9ec823\merkle_hash-3.0.0\src\merkle_node.rs:62:21

62 | let Ok(absolute_path) = Utf8PathBuf::from_path_buf(entry?.path())else{
63 | bail!("Path is not valid UTF8 path")
64 | };
| |______________________^
|
= note: see issue #87335 rust-lang/rust#87335 for more information

Environment:
OS: Windows
Rust Version: rustc 1.64.0 (a55dd71d5 2022-09-19) (system)
Cargo rust version: rust-version = "1.57"

@hristogochev
Copy link
Owner

Are you using Rust 1.65.0?

@CaptainIsaaca
Copy link
Author

CaptainIsaaca commented Nov 20, 2022

Are you using Rust 1.65.0?

Nope. 1.57 (updated in issue body). Rust version is required by the Tauri framework, bumping it up somehow breaks dependencies.

@hristogochev
Copy link
Owner

hristogochev commented Nov 20, 2022

Removed the use of the let-else feature in 741a42.
Can you check if it builds for you now using the newest version (3.0.1)?

@CaptainIsaaca
Copy link
Author

Yes, magically solved my issue. Even no need to bump the version it fetched the new batch automatically.
Thanks for the fix. Great module IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants