-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Allow using a custom Memory Stick storage path #11812
Conversation
From removed settings.
This allows a user to keep their save data on an insertable card, or otherwise. Currently, the UI isn't great - errors are easy to miss, and the path must be typed manually.
-[Unknown] |
UI isn't exactly optimal but it's a good setting to have. Let's do it. |
Someone reported this not working on a Huawei P9+ with Android 8.0, only when putting it on the micro SD card. Other paths working, and a Huawei Y3 with Android 5.0 worked fine. Hmm. Will see if I can test more. Don't have many devices, especially not with micro SD slots... -[Unknown] |
Same problem in Galaxy J7 too. |
Thinking of hiding the feature temporarily for the 1.8.0 release to avoid endless support email, until we can figure this out... |
Basically, depending on the device/ROM and whether permissions were customized, you can't write to external SD cards so easily. However, if you add: "/Android/data/org.ppsspp.ppsspp/" to the path, it will work. Example: "/storage/1234-5678/Android/data/org.ppsspp.ppsspp/". It's possible you might need to also add "files/" at the end if that doesn't work. We could make a selection for this based on the return values of Interestingly, on a device I reproduced this with - both /storage/emulated/0/ and /storage/1234-5678/ were owned by root:sdcard_rw and had the same permissions and selinux context. Sigh. -[Unknown] |
Huh, PPSSPP on my device could create the path. Annoying that there's so much difference between devices here. From what I understand of changes planned in the next Android version, this is only going to get more problematic... -[Unknown] |
This allows a user to keep their save data on an insertable card, or otherwise.
Fixes #9573, possibly also #11115 (actually merging seems dangerous and tricky), possibly #6307. Possibly #11731 too, although the UI isn't ideal for that laser-specific case.
Makes #10199 worse, since it just asks the user to type a path. I briefly looked at opening a "browse for folder" dialog on Android... but then just backed away slowly. But some folder browser would be ideal, and much more useful than just an option to store with the app (since that's not necessarily so great if you have an SD card slot.)
Errors are also a bit easy to miss. It uses the tips to tell you if the path you entered isn't writable. Maybe it should show a proper error screen...
-[Unknown]