[Adhoc] Updated PdpCreate, PdpSend, PdpRecv, GetPdpStat, GetPtpStat #15213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anr2me
commented
Dec 8, 2021
anr2me
commented
- Added another returned error code on PdpCreate
- Allow Sending to non-existing MAC address (except invalid/zero MAC). Fixes one of the issue i found while investigating NBA Ballers Rebound NBA ballers rebound adhoc broken #15042 (comment)
- Discard packets from an IP that can't be translated/resolved into player's MAC address (simple version) to prevent confusing the game, since the source MAC can't be updated, thus may contains invalid/wrong MAC. Also added a TODO to handle unresolvable packets properly.
- Updated GetPdpStat and GetPtpStat due to a possibility for FIONREAD to return 0 even when there is a data that can be received (according to stackoverflow)
…ress). Fixes an issue on NBA Ballers Rebound where players unable to enter Multiplayer Menu again after getting connection issue.
… address (simple version) to prevent confusing the game, since the source MAC won't be updated and may contains invalid MAC. Added TODO to handle unresolvable packets properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.