Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyrie Profile performance issue with vulkan, d3d9/11 #15398

Closed
3 of 5 tasks
BParks21 opened this issue Feb 12, 2022 · 22 comments
Closed
3 of 5 tasks

Valkyrie Profile performance issue with vulkan, d3d9/11 #15398

BParks21 opened this issue Feb 12, 2022 · 22 comments
Labels
Performance Unexpected slow performance issues
Milestone

Comments

@BParks21
Copy link

BParks21 commented Feb 12, 2022

Game or games this happens in

ULUS10107 Valkyrie Profile Lenneth

What area of the game

Any traversable area with different rooms/locations that require loading (dungeons & towns) mainly.

Speed seen in PPSSPP

Drops to 90% speed with vulkan, around 94% with D3D9/11 & remains at 100% with ogl.

GE frame capture and debug statistics

No response

Platform

Windows

Mobile phone model or graphics card

GTX 1080ti

PPSSPP version affected

v1.12.3-889-g50350e13a

Last working version

Not sure

Graphics backend (3D API)

Vulkan, D3D11/9

Any other notes or things you've tried

Game drops to 90% game speed for no reason and audio will hiccup. Even at default settings using vulkan and D3D9/11. Not sure what's going on ogl is fine. Also happens with latest libretro core.

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try changing graphics settings to determine if one causes the slowdown.
  • Include logs or screenshots of issue.
@LunaMoo
Copy link
Collaborator

LunaMoo commented Feb 13, 2022

The problem by description sounds like texture scaling, but can't reproduce on my end with either texture scaling or default settings, at least with PPSSPP proper, not interested in libretro.

@BParks21
Copy link
Author

BParks21 commented Feb 13, 2022

The problem by description sounds like texture scaling, but can't reproduce on my end with either texture scaling or default settings, at least with PPSSPP proper, not interested in libretro.

Happens with scaling off and native resolution.

@anr2me
Copy link
Collaborator

anr2me commented Feb 13, 2022

is this happened only on recent builds?
if it's you should try to find out the last version that worked full speed

@BParks21
Copy link
Author

BParks21 commented Feb 13, 2022

@LunaMoo What version are you testing?

@LunaMoo
Copy link
Collaborator

LunaMoo commented Feb 13, 2022

I tested with fresh copy of v1.12.3-905-g4c095ce06 as well as with my personal build, saw no noticeable difference between backends.

Checking frame graph I can see pretty huge spike in both Vulkan and OGL from decodetex, but I guess my RTX 3060 Ti is faster than GTX 1080 Ti by a decent margin so it's still well within budget to keep running at full speed, weaker hardware would probably see similar drop in OGL as in Vulkan.

@hrydgard hrydgard added the Performance Unexpected slow performance issues label Feb 13, 2022
@hrydgard hrydgard added this to the Future-Prio milestone Feb 13, 2022
@BParks21
Copy link
Author

@hrydgard Are you able to reproduce? I'll do some testing with older builds.

@BParks21
Copy link
Author

BParks21 commented Feb 15, 2022

Yeah I can't produce this on 1.12.3 stable, vulkan is smooth for this game in the last stable release. Did a clean install of the latest dev build and the issue persists so yeah it's definitely an issue, just have to figure out when it started.

@unknownbrackets
Copy link
Collaborator

Have you had any luck determining a build this got slower in? Is it any better in the latest git?

-[Unknown]

@BParks21
Copy link
Author

BParks21 commented Apr 3, 2022

No haven't had a chance to test older builds. It's the same in the latest git.

@ghost
Copy link

ghost commented Apr 11, 2022

Try build before #15162

@BParks21
Copy link
Author

Ok i will try as soon as I can

@ghost
Copy link

ghost commented Apr 15, 2022

This might improve via #15474 or 9b25093

@BParks21
Copy link
Author

BParks21 commented Apr 15, 2022

Valkyrie Profile performance is fixed with Vulkan, but now Crisis Core is crashing after the intro logos on Vulkan and D3D11 not Opengl. Not sure if it's related.

@ghost
Copy link

ghost commented Apr 15, 2022

Valkyrie Profile performance is fixed with Vulkan, but now Crisis Core is crashing after the intro logos on Vulkan and D3D11 not Opengl. Not sure if it's related.

Crashing after intro logo is not related to this issue you must create separate issue about that :)

@hrydgard
Copy link
Owner

I'll take a look at that, might be some bug in the fix.

@hrydgard
Copy link
Owner

Think it should be working now in -1067.

@BParks21
Copy link
Author

Think it should be working now in -1067.

Still crashing to the desktop for me in that version, vulkan and d3d.

@hrydgard
Copy link
Owner

Hmm, ok. I'll take another look. Got some non-default options enabled, like texture scaling?

@BParks21
Copy link
Author

Yes I had xbrz x5 on. Turning it off prevents crashing. Used to work with it on.

@hrydgard
Copy link
Owner

Thanks, I got the crash to reproduce. Will fix.

@BParks21
Copy link
Author

Ok thanks

@hrydgard
Copy link
Owner

hrydgard commented Apr 15, 2022

Fixed in the next build. Gonna close this too, since you're reporting that perf seems ok now.

@hrydgard hrydgard modified the milestones: Future-Prio, Future, v1.13.0 Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Unexpected slow performance issues
Projects
None yet
Development

No branches or pull requests

5 participants