Use sequence numbers instead of a tracking array for depth buffers #15854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
GE emulation
There was a problem hiding this comment.
Right, I agree that using a generation count / sequence number is more straight forward. I think it allows us more options on overlap too.
A thing we haven't thought about yet (and hopefully won't have to...) is if a game renders at an X offset into a depth buffer or something.
-[Unknown]
| } | ||
| } | ||
| // We use a special fragment shader flag to convert color to depth. | ||
| vfb = GetLatestDepthBufferAt(params.fb_address /* !!! */, params.fb_stride); |
There was a problem hiding this comment.
nit: This looks as much like "important, fb was intentional here" as "TODO, gotta change something here."
-[Unknown]
| @@ -2220,6 +2174,7 @@ void FramebufferManagerCommon::ReadFramebufferToMemory(VirtualFramebuffer *vfb, | |||
| // We'll pseudo-blit framebuffers here to get a resized version of vfb. | |||
| if (gameUsesSequentialCopies_) { | |||
| // Ignore the x/y/etc., read the entire thing. | |||
| // TODO: What game did we need this for? | |||
There was a problem hiding this comment.
IIRC, Grand Knights Historia was one of them but I think there were a few. It was because some games would memcpy regions in strips, or many smaller regions from a larger framebuffer.
-[Unknown]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works just as well (Asphalt still works), and is much simpler.
Should have thought of this first, heh.