Cleanup value corrections in config load/save #16608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
added
the
Code Cleanup
|
Oh, that would make sense as an explanation for the iOS crashes. I'll review this tomorrow and might get it into 1.14.1. |
hrydgard
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help #16607 and might fix some other bugs.
Whether Load() or loadGameConfig() is used seems to be a bit dynamic in the code currently, so I figured it was safest to add a dedicated place to cleanup loaded config data or to modify configs before saving them. I think separating it makes it cleaner anyway, though (even if Load vs loadGameConfig were more consistent.)
I suspect on iOS, jit was just getting re-enabled for people and it was crashing from that.
-[Unknown]