Shader generator: Move FS_TEX_ALPHA to a uniform bool. #16763
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16567, the effort to reduce the number of unique shaders/pipelines we generate. This does make a difference and I can't see any performance difference otherwise.
This is the first time we use uniform bools. If needed, can easily switch it to a float. If we were only targeting modern APIs I'd just make a uint bitfield of course.For some reason, this doesn't work with D3D9 yet.works now!Had to expand the uniform buffer again, but will optimize it down again later, though I think it doesn't matter too much.
Needs some testing on older OpenGL before merge.