Android: Make font rendering work even absent support for R4G4B4A4 textures #17022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtures. This shouldn't normally happen as conforming drivers are required to support that texture format, but the software driver that we accidentally choose on Poco C40 (see issue #16391) doesn't. That we choose that driver will be fixed separately. This fix on its own at least lets the user comfortably navigate to settings and switch to OpenGL.
unknownbrackets
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
I think we just always used 4444, probably to save memory I guess?
871260f#diff-03f7dbea1008f668c63f7d6012fd3359c8749044cfaf0e275af78e16b03d8d78R118
-[Unknown]
|
Oops, thanks for catching. -[Unknown] |
|
Yes but R8 saves more memory than 4444. |
|
That's true, using GL_LUMINANCE on GLES2 and GL_RED on GLES3 would be more optimal. But in 2017 I think we only had 32 and 16 bit textures, practically... -[Unknown] |
|
Yeah, true - can't swizzle on those either so would need special shaders. On Vulkan we could easily switch though. Unless we want to support color emoji |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't normally happen as conforming drivers are required to support that texture format, but the software driver that we accidentally choose on Poco C40 (see issue #16391) doesn't.
That we erroneously choose to use that driver will be fixed separately. This fix on its own at least lets the user comfortably navigate to settings and switch to OpenGL. Plus, we might always want to use the new R8 texture path on Android to save a little bit of memory. (We did have that R8 path before, but it didn't work correctly).
I hope these devices with only software Vulkan drivers stay rare. Weird configuration.