Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom touch buttons can't control analog directions #17428

Closed
hrydgard opened this issue May 7, 2023 · 3 comments · Fixed by #17433
Closed

Custom touch buttons can't control analog directions #17428

hrydgard opened this issue May 7, 2023 · 3 comments · Fixed by #17433
Labels
Input/Controller Input and controller issues
Milestone

Comments

@hrydgard
Copy link
Owner

hrydgard commented May 7, 2023

Kind of obscure, but this seems to have broken, I thought it worked.

@hrydgard hrydgard added the Input/Controller Input and controller issues label May 7, 2023
@hrydgard hrydgard modified the milestones: v1.16.0, v1.15.4 May 7, 2023
@iota97
Copy link
Contributor

iota97 commented May 7, 2023

Did a quick bisect:

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
38f4cc4cc97baf1e7c8abe1ee0ba8bb21471c863
8dabcaea7d043bea9ee07d894e959105ea987bf6
526b4f782de8226bc72389b79067b93ab0b41f35
We cannot bisect more!

@hrydgard hrydgard modified the milestones: v1.15.4, v1.16.0 May 8, 2023
@hrydgard
Copy link
Owner Author

hrydgard commented May 8, 2023

Yeah, so it's the controlmapper refactoring, not too surprising..

@hrydgard
Copy link
Owner Author

hrydgard commented May 8, 2023

Found two bugs here, first an oversight that was easy to fix (the actual functionality), then I found that the following doesn't work to print uint64_t values on Windows: StringFromFormat("0x%016lx", newValue). It chops off the upper 32 bits, which is where the analog direction bits were stored in the config... Fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input/Controller Input and controller issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants