Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Software transform: culling bugs with the hardware renderers #18258

Closed
hrydgard opened this issue Sep 27, 2023 · 2 comments · Fixed by #18261
Closed

Software transform: culling bugs with the hardware renderers #18258

hrydgard opened this issue Sep 27, 2023 · 2 comments · Fixed by #18261
Milestone
v1.17.0

Comments

@hrydgard
Copy link
Owner

hrydgard commented Sep 27, 2023 •
edited
Loading

See #18252 , for example, happens when turning off Hardware Transform. Got reports of issues on various mobile devices, but likely happen on others too.

This should be fixed but we should also strongly nudge people towards using hardware transform - it's not really useful to expose software transform as a user setting, really.
@hrydgard hrydgard added this to the v1.17.0 milestone Sep 27, 2023
@hrydgard
Copy link
Owner Author

hrydgard commented Sep 27, 2023 •
edited
Loading

Just a note that this reproduces in Tekken 6 on Mac, holes in the floor.

It does seem like I broke this recently...

@hrydgard
Copy link
Owner Author

Ah, this was broken by #18184 . Turns out there is something bad in my logic in that one after all.

I'm going to just back it out for now, and live with not fixing those overflows.

@hrydgard hrydgard mentioned this issue Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging a pull request may close this issue.

Revert "Merge pull request #18184 from hrydgard/expand-lines-mem-fix" hrydgard/ppsspp
1 participant
@hrydgard