Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should shrink savestate screenshots if too large #18556

Closed
hrydgard opened this issue Dec 15, 2023 · 2 comments · Fixed by #18558
Closed

Should shrink savestate screenshots if too large #18556

hrydgard opened this issue Dec 15, 2023 · 2 comments · Fixed by #18558
Labels
User Interface PPSSPP's own user interface / UX
Milestone

Comments

@hrydgard
Copy link
Owner

It's not really motivated to have 12MB JPEGs as savestate thumbnails, which can happen at 10x render resolution.

Let's downsample to some reasonable size.

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Dec 15, 2023
@hrydgard hrydgard added this to the v1.17.0 milestone Dec 15, 2023
@hrydgard
Copy link
Owner Author

hrydgard commented Dec 15, 2023

actually this seems to already have been fixed, max is 960x544.

I don't see how the user managed to create such a massive screenshot... maybe from an older version.

@hrydgard hrydgard reopened this Dec 15, 2023
@hrydgard
Copy link
Owner Author

Never mind, there are issues, like in "Skip buffer effects" mode, the size restriction isn't applied correctly in all cases. And there might be other loopholes, like Auto mode...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant