Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sceSircs/Infrared support on Android #18684

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

Florin9doi
Copy link
Contributor

@hrydgard
Copy link
Owner

That's really cool! Although extremely niche of course, but I'm happy to merge this.

Not worth implementing the init/deinit functions? Might maximize compatibility to return 0 from init, at least.

What else other than your test program uses it? :)

@hrydgard hrydgard added this to the v1.17.0 milestone Jan 12, 2024
@Florin9doi
Copy link
Contributor Author

What else other than your test program uses it? :)

Only similar homebrew programs. Afaik, it was never used by any official program😀

@hrydgard
Copy link
Owner

hrydgard commented Jan 12, 2024

To fix the build, you'll have to add the new file to the UWP vcprojs and also libretro/common.makefile. When it's green, I'll merge.

Let me know if I should take care of it instead.

@Florin9doi
Copy link
Contributor Author

Not worth implementing the init/deinit functions?

I don't know if they receive any parameter, they are not documented

@hrydgard
Copy link
Owner

OK, I think we can just skip them then.

@anr2me
Copy link
Collaborator

anr2me commented Jan 12, 2024

Not worth implementing the init/deinit functions?

I don't know if they receive any parameter, they are not documented

You can try decompiling the [decrypted] official prx (ie. sircs.prx) file using pspdecompiler to see whether the init syscall took any argument (ie. using a0/a1 register at the start of the subroutine) or not.

@hrydgard hrydgard merged commit 5bb4757 into hrydgard:master Jan 12, 2024
18 checks passed
@Florin9doi Florin9doi deleted the infrared branch January 12, 2024 21:43
@Nemoumbra
Copy link
Contributor

@Florin9doi
I'm personally shocked to know there's an IR port in PSPs (I don't think my PSP Go possesses one). So you're saying this library is official, but no games have used it? Then how do we know of its existence? Where does said sircs.prx come from? Which SDK was it introduced in? So many mysteries...

@Florin9doi
Copy link
Contributor Author

Only PSP1000 (fat) have infrared, this library was known since 2005 and is still present in latest firmware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants